Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all articles
Browse latest Browse all 106942

RSRP-468842: Use type keyword in solution breaks code

$
0
0
Reporter Vianney PHILIPPE (vianney) Vianney PHILIPPE (vianney)
Created Mar 23, 2018 4:56:13 PM
Updated Apr 5, 2018 6:21:31 PM
Subsystem Quick Fixes
Assignee Andrew Karpov (andrew.karpov)
Priority Show-stopper
State Submitted
Type Bug
Fix version 2018.1.1
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
I ran 'Use type keyword in solution' quick fix.

I had the following code :
    public static class WindowsEnumerationServices
{
#region Private types
private delegate bool EnumWindowsDelegate(IntPtr handle, Int32 lParam);

private abstract class Matcher
{
public abstract bool Match(IntPtr handle, Int32 lParam);
protected void AddMatchingResult(IntPtr r)
{
MatchingResults.Add(r);
}
public List<IntPtr> MatchingResults { get; } = new List<IntPtr>(); // This field is mutable because the list is populated by AddMatchingResult
}

private class EmptyMatcher : Matcher
{
public override bool Match(IntPtr handle, Int32 lParam)
{
AddMatchingResult(handle);
return true;
}
}

private class CaptionMatcher : Matcher
...

Which was updated to :
...
private abstract class Matcher
{
public abstract bool Match(IntPtr handle, int lParam);public abstract bool Match(IntPtr handle, int lParam);
protected void AddMatchingResult(IntPtr r)
{
MatchingResults.Add(r);
}
public List<IntPtr> MatchingResults { get; } = new List<IntPtr>(); // This field is mutable because the list is populated by AddMatchingResult
}

private class EmptyMatcher : Matcher
{
public override bool Match(IntPtr handle, int lParam)public override bool Match(IntPtr handle, int lParam)
{
AddMatchingResult(handle);
return true;
}
}
...

Note the duplicated lines :
public abstract bool Match(IntPtr handle, int lParam);public abstract bool Match(IntPtr handle, int lParam);
public override bool Match(IntPtr handle, int lParam)public override bool Match(IntPtr handle, int lParam)

Using Re# 2017.3.3
VS 2015
.NET 4.5.2

Viewing all articles
Browse latest Browse all 106942

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>