Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all articles
Browse latest Browse all 106942

RSRP-153156: resharper failed in changing function return type to void

$
0
0
Reporter Michael Lev (michaellev) Michael Lev (michaellev)
Created Feb 7, 2010 1:12:18 AM
Updated Apr 7, 2018 8:50:30 AM
Resolved Apr 7, 2018 8:50:30 AM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Obsolete
Type Feature
Fix version Backlog
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
I have Resharper 5.0 Beta, Build 5.0 1611.9 on 2010-02-05T15:47:52.

I have little func
private static Enums.StateSystem State(Enums.StateSystem state, string msg)
{
if (StateSystem == state) return StateSystem;
var savedState = StateSystem;
StateSystem = state; // @State()
Log.Info2(" *** [{0}->{1}] after: {2}. {3}", savedState, state, msg, DateTime.Now.ToString());
return StateSystem;
}

Resharper suggested to make return type void. I accepted, but it returned next code:
private static void State(Enums.StateSystem state, string msg)
{
if (StateSystem == state)
{
StateSystem;
return;
}
var savedState = StateSystem;
StateSystem = state; // @State()
Log.Info2(" *** [{0}->{1}] after: {2}. {3}", savedState, state, msg, DateTime.Now.ToString());
StateSystem;
return;
}

The correct code sholud be:
private static void State(Enums.StateSystem state, string msg)
{
if (StateSystem == state)
return;
var savedState = StateSystem;
StateSystem = state; // @State()
Log.Info2(" *** [{0}->{1}] after: {2}. {3}", savedState, state, msg, DateTime.Now.ToString());
return;
}

Viewing all articles
Browse latest Browse all 106942


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>