Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all articles
Browse latest Browse all 106942

RSRP-186320: too much assumption on "expression is always true/false"

$
0
0
Reporter Nemo (inemo) Nemo (inemo)
Created Jul 14, 2010 6:25:58 PM
Updated Apr 7, 2018 11:32:27 AM
Resolved Apr 7, 2018 11:32:27 AM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Obsolete
Type Cosmetics
Fix version No Fix versions
Affected versions 5.0
Fixed In Version ReSharper Undefined
VsVersion All Versions
(not sure whether this is intentional :)

resharper sometimes flags certain expressions as being always true/false (imho) without properly considering consequences of the fix, example:


gbAspectRatio.IsEnabled = !(gbResolution.IsEnabled = false);


after resharpers fix:

gbAspectRatio.IsEnabled = true;


the "!(gbResolution.IsEnabled = false)" is ofc always true, however resharpers suggestion is not equivalent and breaks original code by omitting a property setter

Viewing all articles
Browse latest Browse all 106942

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>