Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all articles
Browse latest Browse all 106942

RSRP-469191: Make Method Non-Static: Issues.

$
0
0
Reporter Lilia Shamsutdinova (Lilia.Shamsutdinova) Lilia Shamsutdinova (Lilia.Shamsutdinova)
Created Apr 10, 2018 5:33:17 PM
Updated Apr 17, 2018 12:40:10 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Show-stopper
State Fixed In Branch
Type Bug
Fix version 2018.2
Affected versions 2018.2
Fixed In Version ReSharper Undefined
VsVersion All Versions

JetBrains ReSharper Ultimate 182.0.20180410.111135-eap00d.

        class MetaInfo
        {
            public string Id { get; set; }
            public string Name { get; set; }

            public static MetaInfo Merge(MetaInfo m1, MetaInfo m2)
            {
                return new MetaInfo
                {
                    Id = m1.Id + m2.Id,
                    Name = m1.Name + m2.Name
                };
            }
        }
  1. Invoke Make Method Non-Static on Merge.
  2. Inspect dialog.

Results:

  1. When dialog just opens and keyboard down arrow is pressed (1 - n times) then nothing happens (second parameter is not selected). Expected result: second parameter is selected after down arrow is pressed one time. NOTE: if keyboard up arrow is pressed and after that down arrow is pressed then second parameter is selected. - Fixed in branch 182-alisa.refactorings.
  2. When dialog just opens and mouse click on second parameter then second parameter is not selected (see screenshot). Expected result: second parameter is selected. - Fixed in branch 182-alisa.refactorings.
  3. If Undo checkbox is selected using keyboard-only input (tabs) then the rectangle around the label is NOT shown (first time). Expected result: rectangle around the label is shown. - Also applicable for "Make Static", "Replace Constructor With Factory Method". - Duplicate of RSRP-469289
  4. If Conflicts dialog appears and Back button is clicked then "Make Method Non-Static" dialog appears small. - Duplicate of RSRP-468840

Viewing all articles
Browse latest Browse all 106942

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>