Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all 106942 articles
Browse latest View live
↧

RSRP-461754: Move To Another Type sends my method to a file R# knows is Generated Code.

October 3, 2018, 3:36 am
$
0
0
Reporter Sam Rueby (Sam.Rueby) Sam Rueby (Sam.Rueby)
Created Nov 15, 2016 7:27:09 PM
Updated Oct 3, 2018 1:36:40 PM
Resolved Oct 3, 2018 1:36:40 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Bug
Fix version Backlog
Affected versions 2018.2
Fixed In Version ReSharper Undefined
VsVersion All Versions
I have a partial class that is defined in two files. One files is generated code. R# knows this because in my R# options, in Code Inspection => Generated Code, the name of the generated code file is in the list of Generated file masks. In another class, I want to move a public static method to the partial class. R# moved the method to the generated code file, not the not-generated code file for the partial class.

JetBrains ReSharper Ultimate 2016.3 EAP 8 Checked Build 107.0.20161110.105731-eap8
This pre-release version will expire in 23 days
ReSharper 2016.3.20161110.111152-eap8
↧
Search

RSRP-224370: Move static method refactoring asks which part of target partial class to move to, shouldn't offer the designer-generated part by default

October 3, 2018, 3:37 am
$
0
0
Reporter Drew Noakes (drewnoakes) Drew Noakes (drewnoakes)
Created Mar 6, 2011 9:24:45 PM
Updated Oct 3, 2018 1:37:09 PM
Resolved Oct 3, 2018 1:37:09 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Usability Problem
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
I like when R# offers a sensible default and I can just hit enter.

Check the screenshot. Unfortunately you can only go on the filename, afaik. I have set this pattern (well, it's there by default) in the 'generated file masks' setting.
↧
↧

RSRP-471736: Move To Another Type: can't select to which part method should be moved in case of partial class.

October 3, 2018, 3:37 am
$
0
0
Reporter Lilia Shamsutdinova (Lilia.Shamsutdinova) Lilia Shamsutdinova (Lilia.Shamsutdinova)
Created Oct 3, 2018 1:36:18 PM
Updated Oct 3, 2018 1:37:09 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Major
State Submitted
Type Usability Problem
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions

JetBrains.ReSharperUltimate.2018.3.EAP1D.Checked.(183.0.20181003.15852-eap01d).
Test solution is attached.

  1. Invoke Refactor This -> Move To Another Type on Abc() in Program.cs.
  2. Set WindowsFormsApp2.Form1 as "Move members to".
  3. Click Next.

Actual result:
Abc() is moved to some part.

Expected result:
Dialog to select to which part method should be moved appears.

NOTE:
Looks like a regression (RSRP-224370).
Files which contains generated code should not be available as "Move to" file.

↧

RSRP-272788: Space key doesn't set check flag in "Move to another type"

October 3, 2018, 3:40 am
$
0
0
Reporter Andrew Serebryansky (marcus23) Andrew Serebryansky (marcus23)
Created Jun 20, 2011 2:04:45 PM
Updated Oct 3, 2018 1:40:03 PM
Resolved Oct 3, 2018 1:40:03 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Major
State Obsolete
Type Bug
Fix version Backlog
Affected versions 6.0 EAP
Fixed In Version ReSharper Undefined
VsVersion All Versions
1. write a class with a static method and a static variable. The variable must be declared higher than method (it's important, issue does not reproduce in different cases) 2. move cursor to method name and press Ctrl-R, Ctrl-O.
3. use TAB button to go to "static members to move" area. When you reach this area the cursor will be under the first row that contains the variable and check box will be unchecked. Check this conditions before move to step 4 4. Press SPACE button. Expected behavior - check box is set in the checked state. Current behavior - check box is still in the unchecked state.

additional information
  • when you move cursor down and after that move it back to the first row then you able to change first row check box state
  • issue is reproducing only when first row is in unchecked state
↧

RSRP-471737: Inline parameter works incorrectly

October 3, 2018, 3:44 am
$
0
0
Reporter Olga Rodygina (olgarodygina) Olga Rodygina (olgarodygina)
Created Oct 3, 2018 1:44:28 PM
Updated Oct 3, 2018 1:44:34 PM
Subsystem Refactorings
Assignee Lilia Shamsutdinova (Lilia.Shamsutdinova)
Priority Normal
State To Reproduce
Type Bug
Fix version No Fix versions
Affected versions 2018.2.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
I am trying to inline one of my parameters but ReSharper breaks it completely.
1. after inlining it adds CancellationToken parameter even though it doesn't exist in inlined parameter
2. created parameters have identical names
↧
↧

RSRP-275078: Move Constant in VB.Net yields uncompilable code

October 3, 2018, 4:12 am
$
0
0
Reporter Sunny Gulati (Sunny.Gulati) Sunny Gulati (Sunny.Gulati)
Created Aug 25, 2011 6:07:06 PM
Updated Oct 3, 2018 2:12:38 PM
Resolved Oct 3, 2018 2:12:38 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Fixed
Type Bug
Fix version Unidentified prior version
Affected versions 6.0
Fixed In Version ReSharper Undefined
VsVersion All Versions

Initial code: 
Public Class TreeNode 
   Public Const NODE_TYPE_LABEL As String = "#LABEL" 
   Public Const NODE_TYPE_LABEL_USAGE As String = "#USAGE"
   Public Const NODE_TYPE_LABEL_COST As String = "#COST"
End Class

Create new class, FooConstants.vb
Public Class Constants
End Class

Right click NODE_TYPE_LABEL, Refactor.. Move..
Select all the constants, move them to FooConstants.vb

Resulting code: (this is invalid - "Shared" is a syntax error below) 
Public Class BenchmarkingConstants
    Public Shared Const NODE_TYPE_LABEL As String = "#LABEL"
    Public Shared Const NODE_TYPE_LABEL_USAGE As String = "#USAGE"
    Public Shared Const NODE_TYPE_LABEL_COST As String = "#COST"
End Class

I have to delete the word "Shared" (pretty easy) to make it compilable.
↧

RSRP-286961: Move refactoring makes changes to files not involved in the refactoring

October 3, 2018, 4:17 am
$
0
0
Reporter Joe White (joewhite) Joe White (joewhite)
Created Dec 16, 2011 8:22:32 PM
Updated Oct 3, 2018 2:17:52 PM
Resolved Oct 3, 2018 2:17:52 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Major
State Obsolete
Type Bug
Fix version Backlog
Affected versions 6.1
Fixed In Version ReSharper Undefined
VsVersion All Versions
If I use the "Move" refactoring to move a static method from a class to the codebehind of a Windows Form, ReSharper will correctly perform all the code changes required by the refactoring. However, it will also do a full reformat on the form's .designer.cs file (including adding "using" directives that would probably confuse the WinForms designer), despite that file having no involvement in the refactoring.

Every time I do such a move, I have to revert changes to the .designer.cs before I check in. If I had made actual changes to the form, and wanted to include them in the same commit, I would have a serious mess on my hands.

ReSharper should not modify files that were not part of the refactoring.
↧

RSRP-297233: 'Move method' fails to resolve a conflict

October 3, 2018, 4:19 am
$
0
0
Reporter Vladimir Reshetnikov (nikov) Vladimir Reshetnikov (nikov)
Created Apr 24, 2012 6:03:51 AM
Updated Oct 3, 2018 2:19:55 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Open
Type Bug
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions 
using System;

class A
{
    public static void Foo() // Move to class B
    {
        var s = new Exception();
    }
}

class B
{
    class var {}
}

Actual result:


using System;

class A
{
}

class B
{
    class var {}

    public static void Foo()
    {
        var s = new Exception(); // error CS0029: Cannot implicitly convert type 'System.Exception' to 'B.var'
    }
}

Expected:

using System;

class A
{
}

class B
{
    class var {}

    public static void Foo()
    {
        Exception s = new Exception(); // OK
    }
}
↧
Search

RSRP-446618: Move Static Method refactoring changes keywords to CLR types

October 3, 2018, 4:24 am
$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created Aug 11, 2015 6:51:52 PM
Updated Oct 3, 2018 2:24:59 PM
Resolved Oct 3, 2018 2:24:59 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Duplicate
Type Bug
Fix version Backlog
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
1) Create a new Console Application;

2) Programs.cs
using System; 
using System.Collections.Generic; 
using System.Linq; 
using System.Text;

namespace ConsoleApplication6 
{ 
class Program 
{ 
static void Main(string[] args) 
{ 
Console.Write(string.Format("{0}", 1)); 
} 
} 
}
3) Class1.cs
using System; 
using System.Collections.Generic; 
using System.Linq; 
using System.Text;

namespace ConsoleApplication6 
{ 
class Class1 
{ 
public static void Test() 
{ 
//body 
} 
} 
}

4) Put the cursor on Test() | Refactor -> Move... | Select "Program" class | Next

5) Result Programs.sc
using System; 
using System.Collections.Generic; 
using System.Linq; 
using System.Text;

namespace ConsoleApplication6 
{ 
class Program 
{ 
static void Main(string[] args) 
{ 
Console.Write(String.Format("{0}", 1)); 
}

public static void Test() 
{ 
//body 
} 
} 
}

"string" keyword has been changed to "String" CRL type

The same happens for e.g. short.MaxValue() -> Int16.MaxValue()
↧
↧

RSRP-196359: "Refactor - Move method" changes "string" to "String"

October 3, 2018, 4:24 am
$
0
0
Reporter Alex Berezoutsky (fergard) Alex Berezoutsky (fergard)
Created Oct 27, 2010 6:22:04 PM
Updated Oct 3, 2018 2:24:59 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Open
Type Bug
Fix version Backlog
Affected versions 2018.2, 6.0
Fixed In Version ReSharper Undefined
VsVersion All Versions
Here's a simple way to reproduce:

1) Create a simple class and add the following method:

        public static string CreateMoveBug()
        {
            if (string.IsNullOrEmpty("Test"))
            {
                return null;
            }

            int.Parse("33");

            decimal.Parse("2.2");

            return string.Empty;
        }
2) Add an inner class to the class created above and name it whatever.

3) Do a refactor Move Method and move the above method into the inner class, the result is the following:

            public static string CreateMoveBug()
            {
                if (String.IsNullOrEmpty("Test"))
                {
                    return null;
                }

                Int32.Parse("33");

                Decimal.Parse("2.2");

                return String.Empty;
            }
I would expect it not to change any of the code of the method but it replaces all the C# aliases with their respective class.
↧

RSRP-330689: Type alias changed if refactor move method

October 3, 2018, 4:24 am
$
0
0
Reporter vilinski (python) vilinski (python)
Created Oct 5, 2012 6:53:49 PM
Updated Oct 3, 2018 2:24:59 PM
Resolved Oct 3, 2018 2:24:10 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Bug
Fix version Backlog
Affected versions 7.1.3, 8.0.2, 8.0.1
Fixed In Version ReSharper Undefined
VsVersion VS10 (2010), VS 2012 RTM U2
1. A method contains method calls of types with alias, for example int.TryParse(...), string.IsNullOrEmpty(...), etc.
2. Make a refactor->move method to another type
3 the types are changed to a not alias name, e.g. int=>Int32, decimal=>Decimal, string=>String
4 the type alias changes are observable not only in moved method, but in entire target class

Affected R# versions are all new inclusive 6.0 until EAP 7.1
↧

RSRP-346293: Resharper changes format of builtin aliases when applying "Move method to another type"

October 3, 2018, 4:24 am
$
0
0
Reporter Vilen Tambovtsev (v.tambovtsev) Vilen Tambovtsev (v.tambovtsev)
Created Mar 20, 2013 2:41:53 PM
Updated Oct 3, 2018 2:24:59 PM
Resolved Oct 10, 2014 9:28:30 PM
Subsystem Psi
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Bug
Fix version Backlog
Affected versions 8.0, 8.1 EAP
Fixed In Version ReSharper Undefined
VsVersion All Versions
For example I had:
var rawRev = ulong.Parse(atr.Value);
string.IsNullOrEmpty(p.Name)
After applying the refactoring I got 
var rawRev = UInt64.Parse(atr.Value);
String.IsNullOrEmpty(p.Name)

Meanwhile I have stylecop plugin installed with a rule that demands me to use builtin aliases and in most cases R# respects this, but in this case it breaks the whole file formatting
↧

RSRP-381897: Move to Another Type does not update the usages

October 3, 2018, 4:29 am
$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created Aug 9, 2013 3:12:49 PM
Updated Oct 3, 2018 2:29:32 PM
Resolved Oct 3, 2018 2:29:32 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Duplicate
Type Bug
Fix version Backlog
Affected versions 8.0
Fixed In Version ReSharper Undefined
VsVersion All Versions
go to “MyTest()” function and hit “F6”. It fails to reference the moved method properly.
↧
↧

RSRP-388740: "Move to another file" in vb.net with "Option Strict On" creates non-compilable code by not inserting required newline

October 3, 2018, 4:34 am
$
0
0
Reporter Anton Lobov (Anton.Lobov) Anton Lobov (Anton.Lobov)
Created Oct 14, 2013 5:25:53 PM
Updated Oct 3, 2018 2:34:06 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Submitted
Type Bug
Fix version Backlog
Affected versions 8.1, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions 
Option Strict On

Imports System.IO

Public Class HumanVB
    Public Name As String
    Public Age As Int32
End Class

Public Class EmployeeVB
    Inherits HumanVB
End Class

Public Class HumansVB
    Inherits List(Of HumanVB)

    Public Function GetHumanVB() As HumanVB
        Dim human = New HumanVB
        Return human
    End Function

    Public Function HasProperty(ByVal properties As IDictionary(Of String, String)) As Boolean
        Dim name As String = "test"
        Dim res As Boolean = False

        Return res
    End Function

End Class

Try to move "HumansVB" class to another file by applying corresponding refactoring.
You'll see the following first line:
Option Strict On Public Class HumansVB
  Inherits List(Of HumanVB)

Newline after "Option Strict On" is required.
↧

RSRP-471738: DeclaredElement should be valid

October 3, 2018, 4:39 am
$
0
0
Reporter Lilia Shamsutdinova (Lilia.Shamsutdinova) Lilia Shamsutdinova (Lilia.Shamsutdinova)
Created Oct 3, 2018 2:36:47 PM
Updated Oct 3, 2018 2:39:26 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Major
State Submitted
Type Exception
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
ReSharperPlatformVs15 Wave 183 Hive _3f3919c0 — JetBrains ReSharper Ultimate 2018.3 EAP 1 D Build 183.0.20181003.10229-eap01d

JetBrains dotCover 2018.3 EAP 1 D Build 2018.3.20181003.13531-eap01d
JetBrains dotMemory 2018.3 EAP 1 D Build 2018.3.20181003.13422-eap01d
JetBrains dotTrace 2018.3 EAP 1 D Build 2018.3.20181003.13542-eap01d
JetBrains ReSharper 2018.3 EAP 1 D Build 2018.3.20181003.13429-eap01d
JetBrains ReSharper C++ 2018.3 EAP 1 D Build 2018.3.20181003.13426-eap01d
JetBrains TeamCity Add-in 2018.3 EAP 1 D Build 2018.3.20181003.13422-eap01d

DeclaredElement should be valid

— EXCEPTION #1/2 [AssertionException]
Message = “DeclaredElement should be valid”
ExceptionPath = Root.InnerException
ClassName = JetBrains.Util.Assertion+AssertionException
Data.ThreadLocalDebugInfo = “RdSignal<RdVoid>: LocalProtocol.LocalProtocolStub.ConflictsPageControl.conflicts.modelElements[0].text.customText[0].click”
Data.ReentrancyGuard.ActionName = NavigateToNode
HResult = COR_E_EXCEPTION=80131500
Source = JetBrains.ReSharper.Feature.Services
StackTraceString = “
 at JetBrains.ReSharper.Feature.Services.Navigation.DefaultDeclaredElementNavigator.Navigate(IDeclaredElement declaredElement, PopupWindowContextSource windowContext, Boolean transferFocus, SolutionFeaturePartsContainer container, Nullable`1 options, TabOptions tabOptions)
…
 at JetBrains.ReSharper.Feature.Services.Navigation.DefaultDeclaredElementNavigator.Navigate(IDeclaredElement declaredElement, PopupWindowContextSource windowContext, Boolean transferFocus, SolutionFeaturePartsContainer container, Nullable`1 options, TabOptions tabOptions)
 at JetBrains.ReSharper.Feature.Services.Navigation.DeclaredElementNavigationService.Navigate(IDeclaredElement declaredElement, PopupWindowContextSource windowContext, Boolean transferFocus, Nullable`1 options, TabOptions tabOptions)
 at JetBrains.ReSharper.Feature.Services.Refactorings.NavigationPoint.<>c__DisplayClass6_0.<.ctor>b__0()
 at JetBrains.ReSharper.Feature.Services.Refactorings.NavigationPoint.<ExecuteNavigate>b__10_0()
 at JetBrains.Threading.ReentrancyGuard.Execute(String name, Action action)
”

— Outer —

— EXCEPTION #2/2 [LoggerException]
Message = “DeclaredElement should be valid”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
Data.ManagedThreadName = <NULL>
Data.SccRevisionShell = “<there are no packages matching the criteria>”
Data.HostProductInfo = “JetBrains ReSharper Ultimate 2018.3 EAP 1 D Build 183.0.20181003.10229-eap01d”
Data.SubProducts.#0 = “JetBrains dotCover 2018.3 EAP 1 D Build 2018.3.20181003.13531-eap01d”
Data.SubProducts.#1 = “JetBrains dotTrace 2018.3 EAP 1 D Build 2018.3.20181003.13542-eap01d”
Data.SubProducts.#2 = “JetBrains ReSharper C++ 2018.3 EAP 1 D Build 2018.3.20181003.13426-eap01d”
Data.SubProducts.#3 = “JetBrains TeamCity Add-in 2018.3 EAP 1 D Build 2018.3.20181003.13422-eap01d”
Data.SubProducts.#4 = “JetBrains ReSharper 2018.3 EAP 1 D Build 2018.3.20181003.13429-eap01d”
Data.SubProducts.#5 = “JetBrains dotMemory 2018.3 EAP 1 D Build 2018.3.20181003.13422-eap01d”
Data.SccRevisionEnv = “
Platform\Core\Shell:
    git::refs/heads/183::c8a5fffcd8622f129233413f1555506cbf85bbb6


Platform\VisualStudio:
    git::refs/heads/183::df0abfa361f9611f560bb5d6668771ff5f5eb09e
”
Data.VsVersion = 15.8.28010.2041
InnerException = “Exception #1 at Root.InnerException”
HResult = COR_E_APPLICATION=80131600
StackTraceString = “
 at JetBrains.Threading.ReentrancyGuard.Execute(String name, Action action)
…
 at JetBrains.Threading.ReentrancyGuard.Execute(String name, Action action)
 at JetBrains.Threading.ReentrancyGuard.ExecuteOrQueue(String name, Action action, TaskPriority priority)
 at JetBrains.ReSharper.Feature.Services.Refactorings.NavigationPoint.ExecuteNavigate()
 at JetBrains.ReSharper.Feature.Services.Refactorings.Conflict.<>c__DisplayClass13_1.<GetText>b__1()
 at JetBrains.Platform.RdFramework.Util.ReactiveEx.<>c__DisplayClass1_0.<Advise>b__0(RdVoid _)
 at JetBrains.Platform.RdFramework.Util.Signal`1.Fire0(Action`1[] listeners, T value)
 at JetBrains.Platform.RdFramework.Util.Signal`1.Fire(T value)
 at JetBrains.Platform.RdFramework.Impl.RdSignal`1.Fire(T value)
 at JetBrains.Platform.RdFramework.Util.ReactiveEx.Fire(ISource`1 me)
 at JetBrains.PsiFeatures.UIInteractive.Refactorings.CommonUI.RefactoringWindows.ConflictsWindow.Click(Object sender, RoutedEventArgs e)
 at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
 at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
 at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
 at System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
 at System.Windows.Controls.Primitives.ButtonBase.OnClick()
 at System.Windows.Controls.Button.OnClick()
 at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
 at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
 at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
 at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
 at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
 at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
 at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
 at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
 at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
 at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
 at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
 at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
 at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
 at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
 at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
 at System.Windows.Input.InputManager.ProcessStagingArea()
 at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
 at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
 at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
 at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
 at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
 at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
 at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
 at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
”
↧
Search

RSRP-470961: “Change Signature”: cannot add/edit parameters purely by keyboard

October 3, 2018, 4:40 am
$
0
0
Reporter Ruslan Khamidullin (HamRusTal) Ruslan Khamidullin (HamRusTal)
Created Aug 7, 2018 4:38:18 PM
Updated Oct 3, 2018 2:40:18 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Submitted
Type Bug
Fix version 2018.3
Affected versions 2018.2
Fixed In Version ReSharper Undefined
VsVersion All Versions
Reproduce:
1. Invoke “Change Signature” refactoring.
2. Press Alt+A to add a parameter.
Expected: The added row's current cell is editable right away.
Actual: Not only is the cell un-editable, F2 does not make it editable either (contrary to the Windows GUI conventions). Typing has no expected effect either, except that letters ‘a’, ‘r’, ‘p’, ‘d’ press the respective side buttons (as if the keys are pressed with Alt).

3. Click the cell to make it editable.
4. Input the parameter type.
5. Press Right/Tab/Enter.
Expected: Input focus moves to the next cell to input the parameter name.
Actual: Nothing happens/ Input focus moves outside of the parameters grid (to the “Add” button)/ The “Next” button is pressed.

6. Click the name cell and input the name.
7. Press Left/Shift+Tab/Shift+Enter to return to the type cell (to amend it).
Expected: Input focus moves to the previous cell.
Actual: Nothing happens/ Input focus moves outside of the parameters grid (to “Return type”)/ The “Next” button is pressed.

8. Add another parameter (2,3,4,6 above).
9. Press Up/Down to go to the previous/next parameter (to amend them).
Expected: Input focus moves to the previous/next cell in the same column.
Actual: Nothing happens (if in the name cell)/ Types drop-down menu opens (if in the type cell).
Note: Drop-down lists should open by Alt+Down/F4 (as per Windows GUI conventions); auto-completion lists should open by Ctrl+Space (or the likes).
↧

RSRP-428348: Move static members refactoring: automatic access right

October 3, 2018, 4:40 am
$
0
0
Reporter Alexander Shvedov (shvedov) Alexander Shvedov (shvedov)
Created Nov 27, 2014 9:34:48 PM
Updated Oct 3, 2018 2:40:42 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
The problem with 'move static members' refactoring is that it produces conflicts (because of broken usages) most of the time.

Let's simplify things a bit: we need only two options for access rights chooser - 'Automatic' (default one) and 'Leave as is' (or even single checkbox like "Fix access rights when moving"). In 'automatic' access rights mode, during refactoring's rebind of usage references, we can retry bind of broken usages multiple times raising visibility level.
↧
↧

RSRP-448621: Move refactor - option to merge classes

October 3, 2018, 4:44 am
$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created Sep 25, 2015 12:27:51 PM
Updated Oct 3, 2018 2:44:30 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
If file already exists at destination - should offer to merge methods into existing class. We only have static methods, so it's very simple to merge in this case. Very common for our workflow - Resharper does not support this scenario.
↧

RSRP-458757: Refactor move-to-other-type caues inconsistent modifiers declaration order on new type

October 3, 2018, 4:54 am
$
0
0
Reporter peter ritchie (peteraritchie) peter ritchie (peteraritchie)
Created May 12, 2016 9:27:48 PM
Updated Oct 3, 2018 2:54:58 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Bug
Fix version Backlog
Affected versions 2018.1.2, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Say I move a method from an existing type as follows:

public static IEnumerable<T> DoSomething<T>(Type type, Func<MemberInfo ,T>selector)
{
  return type.GetMembers().Select(selector);
}
If I enter a new name in the Move dialog, it generates something like this:

static internal class MyNewClass
{
 public static IEnumerable<T> DoSomething<T>(Type type, Func<MemberInfo, T> memberSelector) where T : class
 {
//...
 }
}

I should generate something with correct modifier order, like this:
internal static class MyNewClass
{
 public static IEnumerable<T> DoSomething<T>(Type type, Func<MemberInfo, T> memberSelector) where T : class
 {
//...
 }
}
↧

RSRP-461938: Runaway thread after canceling task

October 3, 2018, 4:56 am
$
0
0
Reporter Sam Rueby (Sam.Rueby) Sam Rueby (Sam.Rueby)
Created Nov 28, 2016 4:47:02 PM
Updated Oct 3, 2018 2:56:05 PM
Subsystem Refactorings
Assignee Lilia Shamsutdinova (Lilia.Shamsutdinova)
Priority Normal
State To Reproduce
Type Performance Problem
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
I moved a static method and R# asked me if I would like to perform automatic move refactoring which I accidentally said yes-to. But I knew nowhere uses the static method so this would be pointless, I canceled the refactor by clicking the "X" of the progress Window. You can tell the thread is still doing the work though, because Visual Studio isn't responding. It took minutes for it to finish (and the machine is not starved for resources).

JetBrains ReSharper Ultimate 2016.3 EAP 10 Build 107.0.20161124.90154-eap10
This pre-release version will expire in 26 days
dotCover 2016.3.20161124.92818-eap10
dotTrace 2016.3.20161124.93157-eap10
ReSharper 2016.3.20161124.91320-eap10
dotMemory 2016.3.20161124.92804-eap10
↧
Viewing all 106942 articles
Browse latest View live
Search
<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>