Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all 106942 articles
Browse latest View live

RSRP-434896: Add quick-fix with combining if clauses option

$
0
0
Reporter Angelina Elycheva (Angelina.Elycheva) Angelina Elycheva (Angelina.Elycheva)
Created Mar 10, 2015 2:04:57 PM
Updated Oct 11, 2018 5:10:22 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Before
if (d2 == 0) return 1; 
if (d1 == 1) return 3;
if (d2 == 1) return 1;
if (d2 == 2) return 3;

After:
if (d2 == 0 || d2 == 1) return 1; 
if (d1 == 1 || d2 == 2) return 3;

RSRP-434916: Incorrect Suggestion (Convert to Auto-Property)

$
0
0
Reporter Denis Abramov (sparky2708) Denis Abramov (sparky2708)
Created Mar 10, 2015 11:54:15 PM
Updated Oct 11, 2018 5:14:00 PM
Resolved Oct 11, 2018 5:14:00 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Obsolete
Type Bug
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
No way R# can convert PathType to auto property without causing a compile error.

Public Class LMPath

Private itsPathType As String
Public ReadOnly Property PathType() As String '<<<< HERE SAYS TO CONVERT TO AUTO-PROPERTY'
Get
Return itsPathType
End Get
End Property

Public Sub New(ByVal pathType As String, ByVal unresolvedPath As String)
Me.itsUnresolvedPath = unresolvedPath
Me.itsPathType = pathType
End Sub
End Class

RSRP-435138: Merge "Remove redundant initializer" and "Join declaration and assignment"

$
0
0
Reporter vilinski (python) vilinski (python)
Created Mar 13, 2015 2:01:00 PM
Updated Oct 11, 2018 5:46:48 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Improvement
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
This is not a bug but a improvement proposal.

The subject quickfix options are available always separate. So you need two actions to fix the variable initialization. It would be smarter to add the "Join declaration and assignment" to the variable action with redundant initializer:
double minAxisY = 0.0d; // <-- cries for improving. but first remove initializer, then first join declaration and assignment
minAxisY = ...;

RSRP-435667: Same Quick Fix and Context Action in VB.NET

$
0
0
Reporter Alex Berezoutsky (fergard) Alex Berezoutsky (fergard)
Created Mar 20, 2015 4:56:58 PM
Updated Oct 11, 2018 5:49:50 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Bug
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
See screen.
QF and CA produce the same code.

Code Sample:
    Public Property Documenter() As DocumenterHtml
Get
Return _docHtml
End Get
Set(ByVal value As DocumenterHtml)
_docHtml = value
End Set
End Property

RSRP-435816: Remove redundant Enumerable.Select.

$
0
0
Reporter NN __ (NN) NN __ (NN)
Created Mar 23, 2015 11:52:26 PM
Updated Oct 11, 2018 5:51:39 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
This code

var q = new[] {1, 2};
var qq = q.Select(p => p + 1).Sum();

Can be rewritten as th following eliminating call to 'Select'.

var q = new[] {1, 2};
var qq = q.Sum(p => p + 1);

RSRP-435962: There should be no "Make class sealed" quickfix for POCO class

$
0
0
Reporter Angelina Elycheva (Angelina.Elycheva) Angelina Elycheva (Angelina.Elycheva)
Created Mar 25, 2015 4:27:00 PM
Updated Oct 11, 2018 5:57:16 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Bug
Fix version Backlog
Affected versions 9.0, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
1. Open attached solution | Department.cs file
2. Put caret on
Courses = new HashSet<Cours>();

Result: ReSharper recommends to make this class sealed, though there're MSDN requirements for POCO class inclining the following one:
A custom data class must not be sealed (NotInheritable in Visual Basic)


Please refer to https://msdn.microsoft.com/en-us/library/vstudio/dd468057(v=vs.100).aspx

RSRP-435975: 'Find all issues of this type in scope' should be a submenu, not a separate dialog

$
0
0
Reporter Dmitry Matveev (Dmitry.Matveev) Dmitry Matveev (Dmitry.Matveev)
Created Mar 25, 2015 10:21:19 PM
Updated Oct 11, 2018 5:58:48 PM
Resolved Oct 11, 2018 5:58:48 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Obsolete
Type Usability Problem
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
Showing the scope options as a submenu would be consistent with the UX of other features
Compare:




and this



Probably, we could only show the dialog if the user selects 'custom scope'

RSRP-436766: 'Add setter' is suggested for a non-user type

$
0
0
Reporter Anton Lobov (Anton.Lobov) Anton Lobov (Anton.Lobov)
Created Apr 2, 2015 2:25:51 PM
Updated Oct 11, 2018 6:04:49 PM
Resolved Oct 11, 2018 6:04:49 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Fixed
Type Bug
Fix version Unidentified prior version
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
Try to assign a value to System.Windows.Forms.ComboBox::Items. You'll get a quickfix for adding a setter. But it's a non-user type.

RSRP-436961: Upgrade type to FQN in ExpectedException attribute

$
0
0
Reporter Alexandra Kuks (Asia.Rudenko) Alexandra Kuks (Asia.Rudenko)
Created Apr 7, 2015 8:23:39 PM
Updated Oct 11, 2018 6:11:02 PM
Resolved Oct 11, 2018 6:11:02 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Obsolete
Type Feature
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
NUnit's ExpectedException attribute can be used with a string specifying the exception:

[Test]
[ExpectedException("ArgumentException")]
public void TestMethod()
{
throw new ArgumentException();
}

– but this test will fail because NUnit requires FQN; attribute should look like [ExpectedException("System.ArgumentException")].
A quickfix that would suggest to transfrom type to FQN would be very nice.

RSRP-437308: VB.NET: Should read "MustOverride" instead of "Abstract" in Quick Fix actions

$
0
0
Reporter Denis Abramov (sparky2708) Denis Abramov (sparky2708)
Created Apr 14, 2015 12:32:43 AM
Updated Oct 11, 2018 6:12:55 PM
Resolved Oct 11, 2018 6:12:55 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Bug
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
Why does that 1 entry say "abstract" and the rest say "MustOverride". To a VB.NET programmer "MustOverride" makes more sense. See picture.

RSRP-337931: Create MustOverride Sub (R# 7.1)

$
0
0
Reporter Denis Abramov (sparky2708) Denis Abramov (sparky2708)
Created Jan 30, 2013 10:57:14 PM
Updated Oct 11, 2018 6:12:55 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Usability Problem
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
I am using VB.NET with R#7.1. So I wanted R# to create the method "Load" for me. Look at the options it is presenting me in the screenshot attached. As a "VB.NET" developer I am looking for "Create MustOverride Sub" which isn't part of the list. Interestingly there is "Create MustOverride Property" and "Create MustOverride ReadOnly Property". After looking at the list I do see "Create abstract class". This should really say "Create MustOverride Sub" for VB.NET developers, VB.NET developers aren't generally thinking of the word "abstract" unless you have a C#/Java background.

JetBrains ReSharper 7.1.1 Full Edition
Build 7.1.1000.900 on 2012-12-13T20:22:48

RSRP-437978: 'Import ... and all other references in file' quick fix adds wrong using statements

$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created Apr 21, 2015 2:29:29 PM
Updated Oct 11, 2018 6:21:24 PM
Resolved Oct 11, 2018 6:21:24 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Fixed
Type Bug
Fix version Unidentified prior version
Affected versions 9.1
Fixed In Version ReSharper Undefined
VsVersion All Versions
Sometimes when I write code and use the 'Import ... and all other references in file' quick fix, ReSharper adds a using statement for a namespace that is not wanted.
I have attached a sample solution where the issue can be reproduced.

See this code:
namespace ReSharperTest 
{
using System.Windows;

/// <summary>
/// Interaction logic for MainWindow.xaml
/// </summary>
public partial class MainWindow : Window
{
private bool anotherOne;

public MainWindow()
{
//Contract.Assert(true);
this.InitializeComponent();
}

[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1726:UsePreferredTerms", MessageId = "Flag")]
public bool LoadedFlag { get; set; }
}
}
When I un-comment the Contract.Assert line and press [Alt+Enter] to have ReSharper insert the appropriate using statement, I get this:
namespace ReSharperTest 
{
using System.Diagnostics.Contracts;
using Microsoft.Office.Interop.Word;
using Window = System.Windows.Window;

/// <summary>
/// Interaction logic for MainWindow.xaml
/// </summary>
public partial class MainWindow : Window
{
private bool anotherOne;

public MainWindow()
{
Contract.Assert(true);
this.InitializeComponent();
}

[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1726:UsePreferredTerms", MessageId = "Flag")]
public bool LoadedFlag { get; set; }
}
}
The using statement for the Word namespace is incorrect and breaks the SuppressMessage line.

Is this a bug?

RSRP-80754: OutOfMemoryException

$
0
0
Reporter Ilya Ryzhenkov (orangy) Ilya Ryzhenkov (orangy)
Created Sep 16, 2008 10:30:37 AM
Updated Oct 11, 2018 6:23:03 PM
Subsystem Crash
Assignee Sergey Shkredov (serjic.shkredov)
Priority Critical
State Reopened
Type Exception
Fix version Backlog
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions

RSRP-438217: Bulk fix for class is never instantiated (make static)

$
0
0
Reporter Sergey Shkredov (serjic.shkredov) Sergey Shkredov (serjic.shkredov)
Created Apr 24, 2015 5:34:45 PM
Updated Oct 11, 2018 6:24:34 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions

RSRP-439301: C# Comments for method parameters - Missing bulk feature

$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created May 7, 2015 4:56:36 PM
Updated Oct 11, 2018 6:27:24 PM
Resolved Oct 11, 2018 6:27:24 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Feature
Fix version Backlog
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
You could add a bulk change feature to remove unused parameter names in comments and add the used ones to existing summary (comments). Right now, you can do one parameter at one time which is very tiresome.

RSRP-62012: it would be cool if one could apply ReSharper suggestions on a per-file or even per-project basis

$
0
0
Reporter Corey Kosak (kosak) Corey Kosak (kosak)
Created Mar 20, 2008 12:37:09 AM
Updated Oct 11, 2018 6:27:40 PM
Subsystem Quick Fixes
Assignee Alexander Shvedov (shvedov)
Priority Major
State Open
Type Feature
Fix version Backlog
Affected versions 2018.1.1
Fixed In Version ReSharper Undefined
VsVersion All Versions
Maybe this feature exists and I don't know about it.

I find myself scrolling through files these days, going to each line where ReSharper suggests "Use var" and accepting its suggestion, on a line-by-line basis. The key is I say "use var" every single time. I am not interested in applying any discretion.

It would be cool if this could be done in batch, like I could say "analyze file" and it would say
  • 173 lines with "use var" suggestion
  • 31 lines with "Field can be made readonly"
  • 3 lines with "Convert to ?: operator"

Then I can click on the refactorings that I like (maybe I like the first two but not the third) and then ReSharper will do them all at once.

(If I did want to use discretion, i.e. if I wanted to browse all 173 lines that ReSharper wanted to change by applying "use var", maybe I could click the 173 open with the usual tree view)

RSRP-415388: "update all xml-comments" quickfix

$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created May 26, 2014 3:57:57 PM
Updated Oct 11, 2018 6:27:40 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
when I add multiple parameters to a method, when you suggest, please ask "update all xml-comments" rather than make me do it one at a time.

RSRP-439608: Compilation error after applying a quickfix

$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created May 13, 2015 11:01:55 AM
Updated Oct 11, 2018 6:30:54 PM
Subsystem Code Analysis - C#
Assignee Ivan Serduk (IvanSerduk)
Priority Critical
State Submitted
Type Bug
Fix version Backlog
Affected versions 9.1, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
using System;

class Program
{
static void Main() {
var x = DateTime.Now.Day > 10 ? 1 : new Program() ?? default(object);
}
}

RSRP-470365: Breakpoints tool window: omit formatting in the 'Copy' action

$
0
0
Reporter Anna Milova (anna.milova) Anna Milova (anna.milova)
Created Jun 27, 2018 11:33:33 PM
Updated Oct 11, 2018 6:32:25 PM
Subsystem UI
Assignee Alexander Ulitin (alexander.ulitin)
Priority Normal
State Submitted
Type Bug
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
Currently the 'Copy' action brings space characters + breakpoint's info + new line, but only breakpoint's info is expected to be copied.


Expected: Employee.cs if (item.Manager != this)

Actual: Employee.cs if (item.Manager != this)
// <-- new line

RSRP-439693: Quick-fix 'Call to Convert.ToDateTime' isn't suggested for nullable type variable

$
0
0
Reporter Angelina Elycheva (Angelina.Elycheva) Angelina Elycheva (Angelina.Elycheva)
Created May 13, 2015 4:46:33 PM
Updated Oct 11, 2018 6:32:53 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Bug
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Please check:
DateTime a = "some date"; //suggests to call Convert.ToDateTime 
DateTime? b = "some date"; //doesn't suggest the Convert call, which it should imo
Viewing all 106942 articles
Browse latest View live


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>