RSRP-438512: Implement sorting by type in type layout

October 11, 2018, 3:46 pm

≫ Next: RSRP-471819: Prefer newline before ) doesn't work with if statements when chopping a long line

≪ Previous: RSRP-471818: "Implicitly captured closure" on local functions that never leave their home method

Reporter	Matt Feemster (mfeemster)
Created	Apr 29, 2015 6:06:01 PM
Updated	Oct 12, 2018 1:46:32 AM
Subsystem	Code Style - Cleanup
Assignee	Eugene Strizhok (Eugene.Strizhok)
Priority	Normal
State	Submitted
Type	Feature
Fix version	No Fix versions
Affected versions	No Affected versions
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

Resharper does not have the ability to sort by type when doing code layout. For example:

//Sort by access, type, then name within that type: public, then char float int (c, f, i alphabetically), then by name within each type.
public char x;
public char y;
public float a;
public float b;
public int m;
public int n;

This should be a standard part of code layout. I suggest adding a "Type" field in the layout editor "sort by" list.

↧

RSRP-471819: Prefer newline before ) doesn't work with if statements when chopping a long line

October 11, 2018, 4:53 pm

≫ Next: RSRP-471576: Type reference could be only for type reference but is used on

≪ Previous: RSRP-438512: Implement sorting by type in type layout

Reporter	Chris Burkhart (ctide)
Created	Oct 12, 2018 2:53:58 AM
Updated	Oct 12, 2018 2:53:58 AM
Subsystem	No Subsystem
Assignee	Unassigned
Priority	Normal
State	Submitted
Type	Unspecified
Fix version	No Fix versions
Affected versions	No Affected versions
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

When we have code such as:

if (m_socket.State == WebSocketState.Closed || m_socket.State == WebSocketState.CloseSent || m_socket.State == WebSocketState.CloseReceived) {

And we have Rider setup to always chop lines longer than 80 characters, and to prefer the closing parens to be on the next line, it appears that isn't respected for if statements. This is refactored into:

if (m_socket.State == WebSocketState.Closed ||
    m_socket.State == WebSocketState.CloseSent ||
    m_socket.State == WebSocketState.CloseReceived) {

Instead of:

if (m_socket.State == WebSocketState.Closed ||
    m_socket.State == WebSocketState.CloseSent ||
    m_socket.State == WebSocketState.CloseReceived
) {

Which is how all other long lines (invocations and method signature declarations, for example) are handled.

↧

RSRP-471576: Type reference could be only for type reference but is used on

October 11, 2018, 11:37 pm

≫ Next: RSRP-434391: ReSharper should detect a possible race condition in event assignment

≪ Previous: RSRP-471819: Prefer newline before ) doesn't work with if statements when chopping a long line

Reporter	Lilia Shamsutdinova (Lilia.Shamsutdinova)
Created	Sep 20, 2018 4:58:04 PM
Updated	Oct 12, 2018 9:37:45 AM
Subsystem	JavaScript
Assignee	Nikita Popov (poksh)
Priority	Normal
State	Submitted
Type	Exception
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

ReSharperPlatformVs15 Wave 183 Hive _3f3919c0ProjectModel — JetBrains ReSharper Ultimate 2018.3 EAP 1 D Build 183.0.20180918.154710-eap01d

JetBrains ReSharper 2018.3 EAP 1 D Build 2018.3.20180918.160255-eap01d

Type reference could be only for type reference but is used on

— EXCEPTION #1/1 [LoggerException]
Message = “Type reference could be only for type reference but is used on”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
Data.ManagedThreadName = “JetPool(L) #7”
Data.SccRevisionShell = “<there are no packages matching the criteria>”
Data.HostProductInfo = “JetBrains ReSharper Ultimate 2018.3 EAP 1 D Build 183.0.20180918.154710-eap01d”
Data.SubProducts.#0 = “JetBrains ReSharper 2018.3 EAP 1 D Build 2018.3.20180918.160255-eap01d”
Data.SccRevisionEnv = “
Platform\Core\Shell:
git::refs/heads/183-deferred-projects::f881e303bc575e4fd458361426a27fbf97c94603

Platform\VisualStudio:
git::refs/heads/183-deferred-projects
”
Data.VsVersion = 15.8.28010.2026
HResult = COR_E_APPLICATION=80131600
StackTraceString = “

 at JetBrains.Util.Logging.Logger.FailWithSensitiveData(String messageText, Pair`2[] sensitiveData)

…

 at JetBrains.Util.Logging.Logger.FailWithSensitiveData(String messageText, Pair`2[] sensitiveData)
 at JetBrains.ReSharper.Psi.JavaScript.Resolve.PrimitiveTypeExtensions.GetTypeReferenceType(JsPrimitive primitive, String name)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.TypeScript.TsTypeBase.ProcessDerivedTypes(JsResolveContext context, JsTypeDescriptionOpInfo& derivedTypeInfo, JsUnresolvedTypeFlags flags, IList`1 sourcePrimitives, JsTypeExpandingContext derivedPrimitives, ResolveErrorType resolveStatus, JsTypeResolveResult contextualType)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.TypeScript.TsTypeWithSignaturesBase.ProcessDerivedTypes(JsResolveContext context, JsTypeDescriptionOpInfo& derivedTypeInfo, JsUnresolvedTypeFlags flags, IList`1 sourcePrimitives, JsTypeExpandingContext derivedPrimitives, ResolveErrorType resolveStatus, JsTypeResolveResult contextualType)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.TypeScript.TsNamedType.ProcessDerivedTypes(JsResolveContext context, JsTypeDescriptionOpInfo& derivedTypeInfo, JsUnresolvedTypeFlags flags, IList`1 sourcePrimitives, JsTypeExpandingContext derivedPrimitives, ResolveErrorType resolveStatus, JsTypeResolveResult contextualType)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsTypeResolverBase.ProcessDerivedTypes(JsTypeResolveResult type, JsResolveContext context, JsTypeDescriptionOpInfo derivedTypeInfo, StrongTypeMode mode, Boolean expectedType, JsUnresolvedTypeFlags flags, Boolean addStandardTypes, JsTypeResolveResult contextualType)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsUnresolvedTypeBase.<>c.<.cctor>b__58_1(JsResolveContext context1, JsUnresolvedTypeBase me, MyCalculationIdentifier ident)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsResolveContext.CalculateWithCache[T,TCalculationIdentifier,TState](TCalculationIdentifier ident, TState state, ResolveContextKind resolveKind, Func`4 getResult, T defaultValue, Boolean checkForCyclicOrTooDeep, Func`4 getCyclicResult, Func`5 processResult)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsUnresolvedTypeBase.ExpandRecursively(JsResolveContext context, Boolean standardTypes, Boolean expectedTypes, JsUnresolvedTypeFlags flags, StrongTypeMode strongTyped, JsTypeResolveResult contextualType)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsUnresolvedTypeBase.<>c.<.cctor>b__58_1(JsResolveContext context1, JsUnresolvedTypeBase me, MyCalculationIdentifier ident)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsResolveContext.CalculateWithCache[T,TCalculationIdentifier,TState](TCalculationIdentifier ident, TState state, ResolveContextKind resolveKind, Func`4 getResult, T defaultValue, Boolean checkForCyclicOrTooDeep, Func`4 getCyclicResult, Func`5 processResult)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsUnresolvedTypeBase.ExpandRecursively(JsResolveContext context, Boolean standardTypes, Boolean expectedTypes, JsUnresolvedTypeFlags flags, StrongTypeMode strongTyped, JsTypeResolveResult contextualType)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Resolve.JsUnresolvedTypeBase.ResolveType(JsResolveContext context, Boolean standardTypes, StrongTypeMode strongTyped, JsTypeResolveResult contextualType)
 at JetBrains.ReSharper.Daemon.JavaScript.Stages.TypeScript.Syntax.TypeScriptOwnInspectionsProcess.VisitTsReferenceName(ITsReferenceName tsReferenceNameParam, IHighlightingConsumer context)
 at JetBrains.ReSharper.Psi.JavaScript.Impl.Tree.TypeScript.TsReferenceName.Accept[TContext](TsTreeNodeVisitor`1 visitor, TContext context)
 at JetBrains.ReSharper.Daemon.JavaScript.Prelude.TypeScript.TsDaemonStageProcessBase.ProcessAfterInterior(ITreeNode element, IHighlightingConsumer consumer)
 at JetBrains.ReSharper.Daemon.JavaScript.Stages.TypeScript.Syntax.TypeScriptOwnInspectionsProcess.ProcessAfterInterior(ITreeNode element, IHighlightingConsumer consumer)
 at JetBrains.ReSharper.Psi.RecursiveElementProcessorExtensions.ProcessDescendants[TContext](ITreeNode root, IRecursiveElementProcessor`1 processor, TContext context)
 at JetBrains.ReSharper.Daemon.JavaScript.Stages.TypeScript.Syntax.TypeScriptOwnInspectionsProcess.<Execute>b__10_0(IJavaScriptFile file, IHighlightingConsumer consumer)
 at JetBrains.ReSharper.Daemon.JavaScript.Prelude.TypeScript.TsDaemonStageProcessBase.HighlightInFile(Action`2 fileHighlighter, Action`1 commiter)
 at JetBrains.ReSharper.Daemon.JavaScript.Stages.TypeScript.Syntax.TypeScriptOwnInspectionsProcess.Execute(Action`1 committer)
 at JetBrains.ReSharper.Feature.Services.Daemon.DaemonProcessBase.RunStage(IDaemonStage stage, DaemonProcessKind processKind, Action`2 commiter, IContextBoundSettingsStore contextBoundSettingsStore, JetHashSet`1 disabledStages)

at JetBrains.ReSharper.Feature.Services.Daemon.DaemonProcessBase.<>c__DisplayClass47_1.<DoHighlighting>g__Stage|2(IDaemonStage stage)

 at JetBrains.ReSharper.Feature.Services.Daemon.DaemonProcessBase.<>c__DisplayClass49_1.<PrepareRunActionForStages>b__0()

…

 at JetBrains.ReSharper.Feature.Services.Daemon.DaemonProcessBase.<>c__DisplayClass49_1.<PrepareRunActionForStages>b__0()
 at JetBrains.Application.Threading.Tasks.TaskBarrier.<>c__DisplayClass22_1.<EnqueueDependentJobs>b__2()
 at JetBrains.Application.Threading.Tasks.TaskHost.AccessViolationCatcher(Action action)
 at JetBrains.Application.Threading.Tasks.TaskHost.<>c__DisplayClass33_0.<Create>b__1(Object state)
 at System.Threading.Tasks.Task.InnerInvoke()
 at System.Threading.Tasks.Task.Execute()
 at System.Threading.Tasks.Task.ExecutionContextCallback(Object obj)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
 at System.Threading.Tasks.Task.ExecuteEntry(Boolean bPreventDoubleExecution)
 at System.Threading.Tasks.TaskScheduler.TryExecuteTask(Task task)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetScheduler.ExecuteTask(Task task)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.EnqueueNextTask()
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.ThreadPoolProc()
     at ANNOTATED: JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread #D.JetPool(L) #7(Action )
 at JetBrains.Util.Reflection.CallStackAnnotation.InvokeAnnotated(String classNameOfNewFrame, String methodNameOfNewFrame, Action actionToAnnotate)
 at JetBrains.Util.Reflection.CallStackAnnotation.CatchAnnotatedInvocation[TClassOfNewFrame](String methodNameOfNewFrame, Action actionToAnnotate)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.<Start>b__20_0()
 at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
 at System.Threading.ThreadHelper.ThreadStart()

”

↧

RSRP-434391: ReSharper should detect a possible race condition in event assignment

October 12, 2018, 12:06 am

≫ Next: RSRP-436958: Add quick fix for ambiguous reference error

≪ Previous: RSRP-471576: Type reference could be only for type reference but is used on

Reporter	Eugene Strizhok (Eugene.Strizhok)
Created	Feb 28, 2015 5:01:36 PM
Updated	Oct 12, 2018 10:06:05 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

See http://blogs.msdn.com/b/cburrows/archive/2010/03/08/events-get-a-little-overhaul-in-c-4-part-ii-semantic-changes-and.aspx for details.

public class Class
  {
    public event EventHandler E;

    public void Method()
    {
      E += Handler; // not thread-safe in C# <4.0
      E = E + Handler; // not thread-safe

      lock (this)
      {
        E += E + Handler; // not thread-safe in C# >3.0
      }
    }

    private void Handler(object sender, EventArgs eventArgs)
    {
      throw new NotImplementedException();
    }
  }

↧

RSRP-436958: Add quick fix for ambiguous reference error

October 12, 2018, 12:17 am

≫ Next: RSRP-468322: Transition failed: Transition from state on event . Cause: JetBrains.Util.Assertion+AssertionException: targetFramework

≪ Previous: RSRP-434391: ReSharper should detect a possible race condition in event assignment

Reporter	Eugene Strizhok (Eugene.Strizhok)
Created	Apr 7, 2015 5:47:44 PM
Updated	Oct 12, 2018 10:17:17 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

Sometimes, when a type implements several interfaces there any two unrelated interface (i.e. not forming a hierarchy) have a member with the same name, one cannot invoke this member on an instance of that type, without having to cast the instance to one of the interface explicitly.
Please, add a quick fix that would allow choosing what interface to cast to, and generate the required code for me.
See the attachment.

↧

RSRP-468322: Transition failed: Transition from state on event . Cause: JetBrains.Util.Assertion+AssertionException: targetFramework

October 12, 2018, 12:18 am

≫ Next: RSRP-440148: Quick-fix to push docs messages to implementations

≪ Previous: RSRP-436958: Add quick fix for ambiguous reference error

Reporter	ReSharper anonymous (resharper)
Created	Jan 24, 2018 7:04:21 PM
Updated	Oct 12, 2018 10:18:49 AM
Resolved	Mar 2, 2018 6:31:19 PM
Subsystem	Unit Testing
Assignee	Eugene Strizhok (Eugene.Strizhok)
Priority	Show-stopper
State	Fixed
Type	Exception
Fix version	2018.1
Affected versions	No Affected versions
Fixed In Version ReSharper	2018.1 EAP 2
VsVersion	All Versions

ReSharperPlatformVs15 Wave 11 Hive _c1dfaa6d — JetBrains ReSharper Ultimate 2017.3.2 Build 111.0.20180122.214952

JetBrains ReSharper 2017.3.2 Build 2017.3.20180123.65153

Transition failed: Transition from state <Disconnected> on event <local::Connect>. Cause: JetBrains.Util.Assertion+AssertionException: targetFrameworkId.IsNetFramework at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.VsTestDiscoveryEngineInvoker.GetTestExecutorPath(PlatformType architecture, TargetFrameworkId targetFrameworkId) at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.VsTestDiscoveryEngineInvoker.Start(PlatformType architecture, TargetFrameworkId targetFrameworkId, ILogger logger) at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.StartRunner() at Appccelerate.StateMachine.Machine.ActionHolders.ArgumentLessActionHolder.Execute(Object argument) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\ActionHolders\ArgumentLessActionHolder.cs:line 37 at Appccelerate.StateMachine.Machine.States.State2.ExecuteEntryAction(IActionHolder actionHolder, ITransitionContext2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 340

— EXCEPTION #1/1 [LoggerException]
Message = “
Transition failed: Transition from state <Disconnected> on event <local::Connect>.
Cause: JetBrains.Util.Assertion+AssertionException: targetFrameworkId.IsNetFramework

 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.VsTestDiscoveryEngineInvoker.GetTestExecutorPath(PlatformType architecture, TargetFrameworkId targetFrameworkId)

…

 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.VsTestDiscoveryEngineInvoker.GetTestExecutorPath(PlatformType architecture, TargetFrameworkId targetFrameworkId)
 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.VsTestDiscoveryEngineInvoker.Start(PlatformType architecture, TargetFrameworkId targetFrameworkId, ILogger logger)
 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.StartRunner()
 at Appccelerate.StateMachine.Machine.ActionHolders.ArgumentLessActionHolder.Execute(Object argument) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\ActionHolders\ArgumentLessActionHolder.cs:line 37
 at Appccelerate.StateMachine.Machine.States.State`2.ExecuteEntryAction(IActionHolder actionHolder, ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 340

”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
Data.ManagedThreadName = <NULL>
Data.SccRevisionShell = “<there are no packages matching the criteria>”
Data.HostProductInfo = “JetBrains ReSharper Ultimate 2017.3.2 Build 111.0.20180122.214952”
Data.SubProducts.#0 = “JetBrains ReSharper 2017.3.2 Build 2017.3.20180123.65153”
Data.SccRevisionEnv = “
Platform\Core\Shell:
git::refs/heads/wave11-eap12-2017.3.2::c403ca4a5a3b169923bb8b8adf43779686a72a06

Platform\VisualStudio:
git::refs/heads/wave11-eap12-2017.3.2::4c4ff398432925e3d5698a50da0892c0be14e02f
”
Data.VsVersion = 15.5.27130.2024
HResult = COR_E_APPLICATION=80131600
StackTraceString = “

 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.<.ctor>b__10(Object sender, TransitionExceptionEventArgs`2 args)

…

 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.<.ctor>b__10(Object sender, TransitionExceptionEventArgs`2 args)
 at Appccelerate.StateMachine.Machine.StateMachine`2.RaiseEvent[T](EventHandler`1 eventHandler, T arguments, ITransitionContext`2 context, Boolean raiseEventOnException) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\StateMachine.cs:line 404
 at Appccelerate.StateMachine.Machine.StateMachine`2.OnExceptionThrown(ITransitionContext`2 context, Exception exception) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\StateMachine.cs:line 260
 at Appccelerate.StateMachine.Machine.Contexts.TransitionContext`2.OnExceptionThrown(Exception exception) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\Contexts\TransitionContext.cs:line 74
 at Appccelerate.StateMachine.Machine.States.State`2.HandleException(Exception exception, ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 307
 at Appccelerate.StateMachine.Machine.States.State`2.HandleEntryActionException(ITransitionContext`2 context, Exception exception) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 357
 at Appccelerate.StateMachine.Machine.States.State`2.ExecuteEntryAction(IActionHolder actionHolder, ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 345
 at Appccelerate.StateMachine.Machine.States.State`2.ExecuteEntryActions(ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 330
 at Appccelerate.StateMachine.Machine.States.State`2.Entry(ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 247
 at Appccelerate.StateMachine.Machine.States.State`2.EnterShallow(ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 285
 at Appccelerate.StateMachine.Machine.States.State`2.EnterHistoryNone(ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 429
 at Appccelerate.StateMachine.Machine.States.State`2.EnterByHistory(ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 263
 at Appccelerate.StateMachine.Machine.Transitions.Transition`2.Fire(ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\Transitions\Transition.cs:line 87
 at Appccelerate.StateMachine.Machine.States.State`2.Fire(ITransitionContext`2 context) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\States\State.cs:line 222
 at Appccelerate.StateMachine.Machine.StateMachine`2.Fire(TEvent eventId, Object eventArgument) in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\Machine\StateMachine.cs:line 230
 at Appccelerate.StateMachine.PassiveStateMachine`2.ProcessQueuedEvents() in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\PassiveStateMachine.cs:line 339
 at Appccelerate.StateMachine.PassiveStateMachine`2.Execute() in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\PassiveStateMachine.cs:line 324
 at Appccelerate.StateMachine.PassiveStateMachine`2.Start() in C:\projects\appccelerate\repos\statemachine\source\Appccelerate.StateMachine\PassiveStateMachine.cs:line 230
 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.Execution.MsTestDiscoveryProtocol.Run()
 at JetBrains.ReSharper.UnitTesting.MSTest.Provider.MsTestMetadataExplorer.<>c__DisplayClass1.<ProcessProject>b__0()
 at System.Threading.Tasks.Task.InnerInvoke()
 at System.Threading.Tasks.Task.Execute()
 at System.Threading.Tasks.Task.ExecutionContextCallback(Object obj)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
 at System.Threading.Tasks.Task.ExecuteEntry(Boolean bPreventDoubleExecution)
 at System.Threading.Tasks.Task.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
 at System.Threading.ThreadPoolWorkQueue.Dispatch()
 at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

”

↧

RSRP-440148: Quick-fix to push docs messages to implementations

October 12, 2018, 12:22 am

≫ Next: RSRP-441013: VB: quick-fix to generate case statement

≪ Previous: RSRP-468322: Transition failed: Transition from state on event . Cause: JetBrains.Util.Assertion+AssertionException: targetFramework

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	May 21, 2015 2:15:26 PM
Updated	Oct 12, 2018 10:22:53 AM
Subsystem	Context Actions
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Improvement
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

It would be nice if there was a quick fix available at the caret to push the docs messages to implementations if the implementation does not have a doc comment

public interface IProjectStructureDateProvider : IProviderDiscovery<IProjectStructureDateProvider> 
{ 
Task<List<SiteDateEndValue>> GetEndActualValues(ParallelDataAccessor accessor, int tlpId, HashSet<int> siteIds); 
Task<List<ProjectStructureDate>> GetByPsspId(ParallelDataAccessor accessor, int psspId);

/// <summary> 
/// Achtung! Die Sichtbarkeit durch ein Infofeld wird nicht berücksichtigt. Wird nur für die Massendatenbearbeitung benötigt 
/// </summary> 
/// <param name="psspId">ProjectStructureServiceProgramId - pssp</param> 
/// <returns></returns> 
Task<List<ProjectStructureDate>> GetByPsspId{{CARET}}WithoutDependingInfoField(ParallelDataAccessor accessor, int psspId); 
Task<List<ProjectStructureDate>> GetBsPsspAndSpdId(ParallelDataAccessor accessor, int psspId, int spdId); 
}

↧

RSRP-441013: VB: quick-fix to generate case statement

October 12, 2018, 12:29 am

≫ Next: RSRP-441133: Quickfix inserts (multiple) tabs before using spaces for indentation in Visual Studio 2010

≪ Previous: RSRP-440148: Quick-fix to push docs messages to implementations

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	Jun 9, 2015 1:04:11 PM
Updated	Oct 12, 2018 10:29:07 AM
Subsystem	Context Actions
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

Enum Themes
Default = 0 
Dark = 1 
Light = 2 
End enum

///...

Select Case Theme 
Case Default | 
Case Dark | automaticly typed 
Case Light | 
End Case

↧

RSRP-441133: Quickfix inserts (multiple) tabs before using spaces for indentation in Visual Studio 2010

October 12, 2018, 12:33 am

≫ Next: RSRP-471321: Resharper 2018.2 Unit test and inspection is disabled in Visual Studio if the first project is not a C# project

≪ Previous: RSRP-441013: VB: quick-fix to generate case statement

Reporter	Marcus Mangelsdorf (Merlin2001)
Created	Jun 11, 2015 12:48:59 PM
Updated	Oct 12, 2018 10:33:35 AM
Resolved	Oct 12, 2018 10:33:35 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Fixed
Type	Bug
Fix version	Unidentified prior version
Affected versions	No Affected versions
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

When applying a visibility quickfix (eg. make private/make public) or completing code snippets, ReSharper 9.1.1 puts tab characters at the beginning of the line before continuing to indent with spaces. See attached screenshots for examples.

Unfortunately, this doesn't seem to be the case for all quickfixes - changing from var to explicit type and vice-versa didn't result in tabs inserted (see according screenshots).

↧

RSRP-471321: Resharper 2018.2 Unit test and inspection is disabled in Visual Studio if the first project is not a C# project

October 12, 2018, 12:36 am

≫ Next: RSRP-441139: Quick-fix for Path.Combine

≪ Previous: RSRP-441133: Quickfix inserts (multiple) tabs before using spaces for indentation in Visual Studio 2010

Reporter	Enigneering HemoSonics (hemosonics)
Created	Aug 30, 2018 5:27:32 PM
Updated	Oct 12, 2018 10:36:45 AM
Subsystem	Platform - VS Integration
Assignee	Sergey Kuks (coox)
Priority	Normal
State	Open
Type	Bug
Fix version	Backlog
Affected versions	2018.2
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

After upgrading to Resharper 2018.2 one of our solutions would not enable the Unit Test or Inspections features in the Reshaper menu. The menu items were there, but stayed disabled (grayed out). The first project in the solution is a custom project type for building Sandcastle (SHFB) help, but the rest of solution is C# projects. I renamed one of the C# projects so its would be ordered first in the solution explorer and the Resharper features became enabled.

This solution was working before the Resharper upgrade to 2018.2.

↧

RSRP-441139: Quick-fix for Path.Combine

October 12, 2018, 12:38 am

≫ Next: RSRP-471820: Cannot create type member declaration '??? x;'

≪ Previous: RSRP-471321: Resharper 2018.2 Unit test and inspection is disabled in Visual Studio if the first project is not a C# project

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	Jun 11, 2015 3:56:28 PM
Updated	Oct 12, 2018 10:38:21 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

LoadFile(Path.Combine(Path.GetDirectoryName(name), name));

equals to

LoadFile(name);

↧

RSRP-471820: Cannot create type member declaration '??? x;'

October 12, 2018, 12:45 am

≫ Next: RSRP-441151: Convert foreach to ForEach

≪ Previous: RSRP-441139: Quick-fix for Path.Combine

Reporter	Lilia Shamsutdinova (Lilia.Shamsutdinova)
Created	Oct 12, 2018 10:41:36 AM
Updated	Oct 12, 2018 10:45:45 AM
Subsystem	Quick Fixes - Create From Usage
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Exception
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

ReSharperPlatformVs15 Wave 183 Hive _3f3919c0 — JetBrains ReSharper Ultimate 2018.3 EAP 3 D Build 183.0.20181011.210625-eap03d

JetBrains dotCover 2018.3 EAP 3 D Build 2018.3.20181011.212140-eap03d
JetBrains dotMemory 2018.3 EAP 3 D Build 2018.3.20181011.211946-eap03d
JetBrains dotTrace 2018.3 EAP 3 D Build 2018.3.20181011.212135-eap03d
JetBrains ReSharper 2018.3 EAP 3 D Build 2018.3.20181011.211857-eap03d
JetBrains ReSharper C++ 2018.3 EAP 3 D Build 2018.3.20181011.211854-eap03d
JetBrains TeamCity Add-in 2018.3 EAP 3 D Build 2018.3.20181011.211855-eap03d

SubProducts.0 = JetBrains dotCover 2018.3 EAP 3 D Build 2018.3.20181011.212140-eap03d
SubProducts.1 = JetBrains dotTrace 2018.3 EAP 3 D Build 2018.3.20181011.212135-eap03d
SubProducts.2 = JetBrains ReSharper C++ 2018.3 EAP 3 D Build 2018.3.20181011.211854-eap03d
SubProducts.3 = JetBrains TeamCity Add-in 2018.3 EAP 3 D Build 2018.3.20181011.211855-eap03d
SubProducts.4 = JetBrains ReSharper 2018.3 EAP 3 D Build 2018.3.20181011.211857-eap03d
SubProducts.5 = JetBrains dotMemory 2018.3 EAP 3 D Build 2018.3.20181011.211946-eap03d

Cannot create type member declaration '??? x;'

— EXCEPTION #1/2 [ElementFactoryException]
Message = “Cannot create type member declaration '??? x;'”
ExceptionPath = Root.InnerException
ClassName = JetBrains.ReSharper.Psi.ElementFactoryException
HResult = COR_E_EXCEPTION=80131500
Source = JetBrains.ReSharper.Psi.CSharp
StackTraceString = “

 at JetBrains.ReSharper.Psi.CSharp.Impl.CSharpElementFactoryImpl.CreateTypeMemberDeclaration(String format, Object[] args)

…

 at JetBrains.ReSharper.Psi.CSharp.Impl.CSharpElementFactoryImpl.CreateTypeMemberDeclaration(String format, Object[] args)
 at JetBrains.ReSharper.Feature.Services.CSharp.Psi.CSharpUnresolvedTypesChooser.CreateTypeUsageNode(String typeName)
 at JetBrains.ReSharper.Feature.Services.CSharp.Psi.CSharpUnresolvedTypesChooser.AddUnresolvedTypes(String typeText, Dictionary`2 result)
 at JetBrains.ReSharper.Refactorings.ChangeSignature.ClrChangeSignatureParameter.GetUnresolvedTypeFactory(ITreeNode resolutionPoint)
 at JetBrains.ReSharper.Refactorings.ChangeSignature.ClrChangeSignatureParameter.get_ParameterType()
 at JetBrains.ReSharper.Refactorings.CSharp.ChangeSignature.CSharpChangeSignatureModel.BuildParameters(IParametersOwner parametersOwner, ISubstitution substitution)
 at JetBrains.ReSharper.Refactorings.ChangeSignature.ChangeSignatureRefactoring.Execute(IProgressIndicator pi)
 at JetBrains.ReSharper.Intentions.CSharp.QuickFixes.CreateParameterFromUsageBulbAction.ChangeSignature(IExpression referenceExpression, IParametersOwner parametersOwner, IProgressIndicator progress, Int32& createdParameterIndex)
 at JetBrains.ReSharper.Intentions.CSharp.QuickFixes.CreateParameterFromUsageBulbAction.ExecutePsiTransaction(ISolution solution, IProgressIndicator progress)
 at JetBrains.ReSharper.Feature.Services.Bulbs.BulbActionBase.<>c__DisplayClass0_4.<Execute>b__1()
 at JetBrains.ReSharper.Psi.Transactions.PsiTransactions.Execute(String commandName, Action handler)

”

— Outer —

— EXCEPTION #2/2 [LoggerException]
Message = “Cannot create type member declaration '??? x;'”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
Data.ManagedThreadName = <NULL>
Data.LastExtension = cs
Data.SccRevisionShell = “<there are no packages matching the criteria>”
Data.HostProductInfo = “JetBrains ReSharper Ultimate 2018.3 EAP 3 D Build 183.0.20181011.210625-eap03d”
Data.SubProducts.#0 = “JetBrains dotCover 2018.3 EAP 3 D Build 2018.3.20181011.212140-eap03d”
Data.SubProducts.#1 = “JetBrains dotTrace 2018.3 EAP 3 D Build 2018.3.20181011.212135-eap03d”
Data.SubProducts.#2 = “JetBrains ReSharper C++ 2018.3 EAP 3 D Build 2018.3.20181011.211854-eap03d”
Data.SubProducts.#3 = “JetBrains TeamCity Add-in 2018.3 EAP 3 D Build 2018.3.20181011.211855-eap03d”
Data.SubProducts.#4 = “JetBrains ReSharper 2018.3 EAP 3 D Build 2018.3.20181011.211857-eap03d”
Data.SubProducts.#5 = “JetBrains dotMemory 2018.3 EAP 3 D Build 2018.3.20181011.211946-eap03d”
Data.SccRevisionEnv = “
Platform\Core\Shell:
git::refs/heads/183::e8da202e95830a8340b706e0b9ff840103413034

Platform\VisualStudio:
git::refs/heads/183::867968ccc2dfb96e9f0fcea2e771db649cfa83cf
”
Data.VsVersion = 15.8.28010.2046
InnerException = “Exception #1 at Root.InnerException”
HResult = COR_E_APPLICATION=80131600
StackTraceString = “

 at JetBrains.ReSharper.Psi.Transactions.PsiTransactions.Execute(String commandName, Action handler)

…

 at JetBrains.ReSharper.Psi.Transactions.PsiTransactions.Execute(String commandName, Action handler)
 at JetBrains.ReSharper.Feature.Services.Bulbs.BulbActionBase.<>c__DisplayClass0_3.<Execute>b__0(IProgressIndicator progress)
 at JetBrains.UI.SrcView.Progress.UITaskExecutorRun.RunStartTaskCallTaskAction(IProperty`1 isDone, ProgressIndicator progressIndicator, TaskThreadAffinity taskThreadAffinity, Action`1 FTask, JetDispatcher dispatcherPrimary)
 at JetBrains.UI.SrcView.Progress.UITaskExecutorRun.<>c__DisplayClass11_0.<RunStartTask>b__0()
 at JetBrains.Threading.JetDispatcher.Closure.Execute()
 at JetBrains.Util.Concurrency.WinJetDispatcher.ProcessQueue(Int32 nMinBucket)
 at JetBrains.Util.Concurrency.WinJetDispatcher.<>c__DisplayClass18_0.<BeginInvokeCore>b__0()
 at System.Windows.Threading.DispatcherOperation.InvokeDelegateCore()
 at System.Windows.Threading.DispatcherOperation.InvokeImpl()
 at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
 at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
 at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
 at System.Windows.Threading.DispatcherOperation.Invoke()
 at System.Windows.Threading.Dispatcher.ProcessQueue()
 at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
 at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
 at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
 at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
 at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
 at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
 at System.Windows.Forms.Application.ThreadContext.LocalModalMessageLoop(Form form)
 at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
 at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
 at System.Windows.Forms.Application.RunDialog(Form form)
 at System.Windows.Forms.Form.ShowDialog(IWin32Window owner)
 at System.Windows.Forms.Form.ShowDialog()
 at JetBrains.UI.SrcView.Progress.UITaskExecutorRun.RunCore(TaskThreadAffinity taskThreadAffinity, Action`1 FTask, Func`3 FAttachUi, ProgressIndicator progressIndicator, IWin32Window parentWindow, IThreading threading, WorkerThreadShop workerThreadShop, Boolean enforceModalityState)
 at JetBrains.UI.SrcView.Progress.UITaskExecutorRuns.ExecuteTask(String name, TaskCancelable cancelable, Action`1 task)
 at JetBrains.ReSharper.Feature.Services.Bulbs.BulbActionBase.Execute(ISolution solution, ITextControl textControl)
 at JetBrains.ReSharper.Feature.Services.Intentions.IntentionAction.MyExecutableProxi.Execute()
 at JetBrains.Application.UI.Controls.BulbMenu.Keys.BulbActionKey.Clicked()
 at JetBrains.Application.UI.Controls.GotoByName.BulbMenuComponent.<>c__DisplayClass29_0.<InitMenuGeneral>b__0(Object objKey)
 at JetBrains.DataFlow.Signal`1.NotifySinks(TValue payload)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value, Object cookie)
 at JetBrains.Application.UI.Controls.JetPopupMenu.JetPopupMenu.<>c__DisplayClass49_0.<InitViewModel>b__3(JetPopupMenuItem item)
 at JetBrains.DataFlow.Signal`1.NotifySinks(TValue payload)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value, Object cookie)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value)
 at JetBrains.DataFlow.Signal`1.NotifySinks(TValue payload)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value, Object cookie)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value)
 at JetBrains.Application.UI.Controls.JetPopupMenu.Detail.JetPopupMenuDoc.ExecuteSelectedItem()
 at JetBrains.UI.SrcView.Controls.JetPopupMenu.Impl.JetPopupMenuMainpartView.OnKeyDownLowPriority(KeyEventArgs args)
 at JetBrains.UI.SrcView.Controls.JetPopupMenu.Impl.JetPopupMenuView.OnKeyDown(KeyEventArgs args)
 at System.Windows.Forms.Control.ProcessKeyEventArgs(Message& m)
 at System.Windows.Forms.Control.ProcessKeyMessage(Message& m)
 at System.Windows.Forms.Control.WmKeyChar(Message& m)
 at System.Windows.Forms.Control.WndProc(Message& m)
 at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
 at System.Windows.Forms.Form.WndProc(Message& m)
 at JetBrains.UI.SrcView.Controls.JetPopupMenu.Impl.JetPopupMenuView.WndProc(Message& m)
 at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
 at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
 at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
 at System.Windows.Forms.NativeWindow.DefWndProc(Message& m)
 at JetBrains.UI.Utils.DpiUtil.TopLevelWindowDpiTracker.WndProc(Message& m)
 at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
 at JetBrains.Interop.WinApi.User32Dll.DispatchMessageW(MSG* lpmsg)
 at JetBrains.Util.Concurrency.WinJetDispatcher.WinJetDispatcherStaticMethods.InternalPumpMessagesOnce()
 at JetBrains.Util.Concurrency.WinJetDispatcher.WinJetDispatcherStaticMethods.JetBrains.Util.Concurrency.IJetDispatcherStaticMethods.Run(Func`1 condition, TimeSpan timeout, Boolean bThrowOnTimeout)
 at JetBrains.UI.SrcView.Controls.JetPopupMenu.JetPopupMenuOverlordView.Show(Boolean isModal)
 at JetBrains.Application.UI.Controls.JetPopupMenu.JetPopupMenus.ShowCore(JetPopupMenu menu, ShowWhen when, Boolean isModal, LifetimeDefinition lifetimeDefinitionOptional, IJetPopupMenuOverlordView parentView)
 at JetBrains.Application.UI.Controls.GotoByName.BulbMenuComponent.ShowBulbMenuAdvanced(IEnumerable`1 menuItems, PopupWindowContextSource contextSource, GotoByNameModel gotoByNameModel, Action`1 modelInitHandler, LifetimeDefinition viewLifetimeDefinition, IAutomation captionAutomation, Action`1 beforeShow)
 at JetBrains.ReSharper.Intentions.Bulbs.BulbOnGutterMarginIndicator.<ExecuteIndicator>b__18_0(IList`1 menuItems, PopupWindowContextSource contextSource, GotoByNameModel gotoByNameModel, Action`1 modelInitHandler, LifetimeDefinition definition)
 at JetBrains.ReSharper.Intentions.Bulbs.BulbOnGutterMarginIndicator.DoExecuteIndicator(IDataContext context, BulbItemsReadyState readyState, Action`5 showBulbAction)
 at JetBrains.ReSharper.Intentions.Bulbs.BulbOnGutterMarginIndicator.ExecuteIndicator(IDataContext context, BulbItemsReadyState readyState)
 at JetBrains.ReSharper.Intentions.Bulbs.IndicatorControllerBase.HandleAction(IDataContext context)
 at JetBrains.ReSharper.Intentions.Bulbs.AltEnterHandlers.HandleAction(IDataContext context)
 at JetBrains.ReSharper.Intentions.Bulbs.AltEnterActionHandler.Execute(IDataContext context, DelegateExecute nextExecute)
 at JetBrains.Application.UI.ActionsRevised.Handlers.ExecutableActionEvaluator.Execute(IAction action, IReadOnlyCollection`1 allActions, IDataContext dataContext)
 at JetBrains.Application.UI.ActionsRevised.Handlers.EvaluatedAction.ExecuteWithoutRequirements()
 at JetBrains.Application.UI.ActionsRevised.Handlers.EvaluatedAction.<>c__DisplayClass21_1.<PrepareRequirementsAsync>b__0()
 at JetBrains.Application.UI.ActionSystem.ActionsRevised.Handlers.RequirementsManager.ExecuteActionAsync(IActionRequirement requirement, Action continueWith, Action failWith, Boolean reSharperIsThinking)
 at JetBrains.Application.UI.ActionsRevised.Handlers.EvaluatedAction.PrepareRequirementsAsync(OuterLifetime lifetime, Func`1 executeWhenRequirementsReady, Action`1 failWith)
 at JetBrains.Application.UI.ActionsRevised.Handlers.EvaluatedAction.Execute()
 at JetBrains.VsIntegration.Shell.Actions.Revised.VsOleCommandTargetHandler.<>c__DisplayClass17_0.<CommandTargetExec>b__0()
 at JetBrains.Threading.ReentrancyGuard.Execute(String name, Action action)
 at JetBrains.Threading.ReentrancyGuard.TryExecute(String name, Action action)
 at JetBrains.VsIntegration.Shell.Actions.Revised.VsOleCommandTargetHandler.CommandTargetExec(CommandID commandid, OLECMDEXECOPT cmdExecOpt)
 at JetBrains.VsIntegration.Shell.Actions.Revised.VsOleCommandTargetHandler.<.ctor>b__12_2(CommandID commandid, OLECMDEXECOPT opt, IntPtr in, IntPtr out)
 at JetBrains.VsIntegration.Shell.Package.VsPackageSdkStub.Microsoft.VisualStudio.OLE.Interop.IOleCommandTarget.Exec(Guid& guidGroup, UInt32 nCmdId, UInt32 nCmdExcept, IntPtr vIn, IntPtr vOut)

”

↧

RSRP-441151: Convert foreach to ForEach

October 12, 2018, 12:48 am

≫ Next: RSRP-441477: Quick-fix suggesting to inherit from class

≪ Previous: RSRP-471820: Cannot create type member declaration '??? x;'

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	Jun 11, 2015 4:27:31 PM
Updated	Oct 12, 2018 10:48:37 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

foreach (string name in names) 
{ 
LoadFile(name); 
}

can be converted into

names.ToList().ForEach(LoadFile);

↧

RSRP-441477: Quick-fix suggesting to inherit from class

October 12, 2018, 12:54 am

≫ Next: RSRP-465242: Create type from usage doesn't work in "is" type checking

≪ Previous: RSRP-441151: Convert foreach to ForEach

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	Jun 16, 2015 4:15:11 PM
Updated	Oct 12, 2018 10:54:52 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

When argument type is not assignable to parameterType and argument is User defined class. suggest inherit from class
In one of my projects i forgot to inherit parent class. So i thougt it may be good to put this suggestion behind others:

class Parent
    {
        public void B(Parent type)
        {
        }
    }

 class Child //not inherited by mistake 
    {
        void A()
        {
            Child c = new Child();
            B(c); // inherit from class Parent
}

}

↧

RSRP-465242: Create type from usage doesn't work in "is" type checking

October 12, 2018, 12:59 am

≫ Next: RSRP-441789: Incorrect handling of dynamic object with is and as operators

≪ Previous: RSRP-441477: Quick-fix suggesting to inherit from class

Reporter	Alexander Ulitin (alexander.ulitin)
Created	Jun 28, 2017 12:08:51 PM
Updated	Oct 12, 2018 10:59:55 AM
Subsystem	Quick Fixes - Create From Usage
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Bug
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

//cc: Alexander Shvedov

↧

RSRP-441789: Incorrect handling of dynamic object with is and as operators

October 12, 2018, 1:25 am

≫ Next: RSRP-442195: Add option to fix in scope 'Use object initializer' quick-fix

≪ Previous: RSRP-465242: Create type from usage doesn't work in "is" type checking

Reporter	Alexander Kurakin (Alexander.Kurakin)
Created	Jun 19, 2015 3:37:33 PM
Updated	Oct 12, 2018 11:25:51 AM
Resolved	Oct 12, 2018 11:25:51 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Major
State	Obsolete
Type	Bug
Fix version	Backlog
Affected versions	9.1.1
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

Consider this code:

dynamic transaction;

if (deserialiseResponse.Data is DocumentTransaction) 
{ 
transaction = (DocumentTransaction) deserialiseResponse.Data; 
} 
else if (deserialiseResponse.Data is Reconciliation) 
{ 
transaction = (Reconciliation) deserialiseResponse.Data; 
} 
else 
{ 
transaction = deserialiseResponse.Data; 
}

Resharper offers to use 'as and check for null', and if you accept it produces this:

var data = deserialiseResponse.Data as DocumentTransaction; 
if (data != null) 
{ 
transaction = data; 
} 
else if (deserialiseResponse.Data is Reconciliation) 
{ 
transaction = (Reconciliation) deserialiseResponse.Data; 
} 
else 
{ 
transaction = deserialiseResponse.Data; 
}

This is inappropriate in the situation outlined, as the if..else options are for different types.

If you then try to follow Resharper's hint and change the code yourself to this:

dynamic transaction;

if (deserialiseResponse.Data as DocumentTransaction != null) 
{ 
transaction = (DocumentTransaction) deserialiseResponse.Data; 
} 
else if (deserialiseResponse.Data is Reconciliation) 
{ 
transaction = (Reconciliation) deserialiseResponse.Data; 
} 
else 
{ 
transaction = deserialiseResponse.Data; 
}

Resharper complains that 'try cast and check for null can be replaced with type check'. If you allow Resharper to perform the refactoring it puts it back to the original code and round and round we go in a circle!!

↧

RSRP-442195: Add option to fix in scope 'Use object initializer' quick-fix

October 12, 2018, 1:27 am

≫ Next: RSRP-442739: ReSharper does not offer to apply multiple refactorings once to the whole file

≪ Previous: RSRP-441789: Incorrect handling of dynamic object with is and as operators

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	Jun 24, 2015 2:34:32 PM
Updated	Oct 12, 2018 11:27:31 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

Get whole File and Project fix for class initializer using bracket done by resharper. Currently this is done one instance at a time.

var foo = new Foo(); 
foo.Member1 = something;

var foo = new Foo { Member1 = something};

↧

RSRP-442739: ReSharper does not offer to apply multiple refactorings once to the whole file

October 12, 2018, 1:29 am

≫ Next: RSRP-446019: Apply 'Use conditional access' through file/project/solution

≪ Previous: RSRP-442195: Add option to fix in scope 'Use object initializer' quick-fix

Reporter	Alexander Kurakin (Alexander.Kurakin)
Created	Jul 2, 2015 3:04:37 PM
Updated	Oct 12, 2018 11:29:54 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Major
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

I have (after several refactorings) such a situation:

public interface IOriginalPropertiesSet 
{ 
string Property01 { get; set; } 
int Property02 { get; set; } 
} 
public class DerivedLevel01 : IOriginalPropertiesSet 
{ 
public virtual string Property01 { get; set; } 
public virtual int Property02 { get; set; } 
} 
public class DerivedLevel02 : DerivedLevel01 
{ 
public string Property01 { get; set; } 
public int Property02 { get; set; } 
public bool Property03 { get; set; } 
}

When I click on a property (01 or 02) in the DerivedLevel02 class, ReSharper offers to set the property override (and, alternatively, make in new, what is out of my interest).
There's nothing wrong, but I expect to have an option 'apply it to the whole file' (in many refactoing there are these options like 'apply to a file', 'apply to a project', 'apply to the whole solution'). I'm talking about the second-level context menu on the left side of text editing pane in Studio, where various colorful icons of ReSharper are usually shown.

↧

RSRP-446019: Apply 'Use conditional access' through file/project/solution

October 12, 2018, 1:34 am

≫ Next: RSRP-446459: Create an enum based on a switch/case on strings or ints

≪ Previous: RSRP-442739: ReSharper does not offer to apply multiple refactorings once to the whole file

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	Aug 2, 2015 10:40:43 PM
Updated	Oct 12, 2018 11:34:02 AM
Resolved	Oct 12, 2018 11:34:02 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Fixed
Type	Feature
Fix version	Unidentified prior version
Affected versions	No Affected versions
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

Apply 'Use conditional access' quick-fix through file/project/solution

↧

RSRP-446459: Create an enum based on a switch/case on strings or ints

October 12, 2018, 1:37 am

≫ Next: RSRP-446656: Wrong code is produced after applying a convert quickfix for IEnumerable

≪ Previous: RSRP-446019: Apply 'Use conditional access' through file/project/solution

Reporter	Angelina Elycheva (Angelina.Elycheva)
Created	Aug 7, 2015 12:27:40 PM
Updated	Oct 12, 2018 11:37:28 AM
Subsystem	Quick Fixes
Assignee	Alisa Afonina (alisa.afonina)
Priority	Normal
State	Submitted
Type	Feature
Fix version	Backlog
Affected versions	2018.3
Fixed In Version ReSharper	Undefined
VsVersion	All Versions

create an enum based on a switch/case on strings or ints

↧