Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all 106942 articles
Browse latest View live
↧

RSRP-287496: 'Create method from usage' should create generic method where necessary

October 15, 2018, 6:31 am
$
0
0
Reporter Vladimir Reshetnikov (nikov) Vladimir Reshetnikov (nikov)
Created Dec 30, 2011 1:54:15 AM
Updated Oct 15, 2018 4:31:03 PM
Resolved Oct 15, 2018 4:31:03 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Fixed
Type Bug
Fix version Unidentified prior version
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions 
using System.Collections.Generic;

class Program
{
    static void Foo<T>(List<T> x)
    {
        Bar(x); // Create Bar from usage
    }
}

Actual result:

using System.Collections.Generic;

class Program
{
    static void Foo<T>(List<T> x)
    {
        Bar(x); // error CS1503: Argument 1: cannot convert from 'System.Collections.Generic.List<T>' to 'System.Collections.Generic.List<object>'
    }

    private static void Bar(List<object> objects)
    {
        throw new System.NotImplementedException();
    }
}

Expected:

using System.Collections.Generic;

class Program
{
    static void Foo<T>(List<T> x)
    {
        Bar(x); // OK
    }

    private static void Bar<T>(List<T> x)
    {
        throw new System.NotImplementedException();
    }
}
↧
Search

RSRP-287574: Add parameter option not available for named parameters

October 15, 2018, 6:33 am
$
0
0
Reporter Hadi Hariri (hadihariri) Hadi Hariri (hadihariri)
Created Jan 4, 2012 11:55:08 AM
Updated Oct 15, 2018 4:33:30 PM
Resolved Oct 15, 2018 4:33:30 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Bug
Fix version Backlog
Affected versions 6.1.1
Fixed In Version ReSharper Undefined
VsVersion All Versions
I have a method

void Foo(Bar bar)

I have a code that calls it

this.Foo(someBar);

I change it to

this.Foo(someBar, thisWillBeAnInt:5);

I expect alt+Enter to allow me now to add a parameter from that usage but all it offers me is to create an overload
If I make the 2nd argument non-named ReSharper does give me an option to add a parameter for the int
↧
↧

RSRP-329850: Suggest user to modify method signature when using named arguments

October 15, 2018, 6:33 am
$
0
0
Reporter Kirill Orlov (diverofdark) Kirill Orlov (diverofdark)
Created Sep 10, 2012 9:29:59 PM
Updated Oct 15, 2018 4:33:30 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Improvement
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Let's see at following code:
        private void doSomething(int a=0,int b=1, int c=2);

doSomething(b:9, {caret}d:10)

There should be an quickFix which adds new parameter for existing method.
↧

RSRP-428006: "Add parameter" refactoring option is not offered when using named parameters

October 15, 2018, 6:33 am
$
0
0
Reporter Alexey Yeltsov (Alexey.Yeltsov) Alexey Yeltsov (Alexey.Yeltsov)
Created Nov 21, 2014 12:24:06 AM
Updated Oct 15, 2018 4:33:30 PM
Resolved Nov 26, 2014 7:13:48 PM
Subsystem Refactorings - Inplace
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Bug
Fix version No Fix versions
Affected versions 9.0 EAP
Fixed In Version ReSharper Undefined
VsVersion All Versions
In the following code, with the first call of SomeMethod R# offers to add parameter to SomeMethod.
However, for the second call R# only offers to create overload

namespace ConsoleApplication3
{
    public class MyClass
    {
        public string MyString;

        public void SomeMethod(string someString)
        {
            this.MyString = someString;
        }

        private static void Bar()
        {
            MyClass myClass = new MyClass();

            myClass.SomeMethod("", 33);

            myClass.SomeMethod(someString: "", myInt1: 33);
        }
    }
}
↧

RSRP-287685: 'Create method from usage' creates incompatible signature

October 15, 2018, 6:34 am
$
0
0
Reporter Vladimir Reshetnikov (nikov) Vladimir Reshetnikov (nikov)
Created Jan 10, 2012 10:43:11 PM
Updated Oct 15, 2018 4:34:47 PM
Resolved Oct 15, 2018 4:34:47 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Fixed
Type Bug
Fix version Unidentified prior version
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions 
using System;
using System.Collections.Generic;


class B<S>
{
    public virtual void Foo<T>(Dictionary<T, S> x)
    {
    }
}

class C : B<string>
{
    public override void Foo<T>(Dictionary<T, string> x)
    {
        Bar(x); // Create Bar from usage
    }
}

Actual:

using System;
using System.Collections.Generic;


class B<S>
{
    public virtual void Foo<T>(Dictionary<T, S> x)
    {
    }
}

class C : B<string>
{
    public override void Foo<T>(Dictionary<T, string> x)
    {
        Bar(x); // error CS1503: Argument 1: cannot convert from 'System.Collections.Generic.Dictionary<T,string>' to 'System.Collections.Generic.Dictionary<object,string>'
    }

    private void Bar(Dictionary<object, string> dictionary)
    {
        throw new NotImplementedException();
    }
}

Expected:

using System;
using System.Collections.Generic;


class B<S>
{
    public virtual void Foo<T>(Dictionary<T, S> x)
    {
    }
}

class C : B<string>
{
    public override void Foo<T>(Dictionary<T, string> x)
    {
        Bar(x); // OK
    }

    private void Bar<T>(Dictionary<T, string> dictionary)
    {
        throw new NotImplementedException();
    }
}
↧
↧

RSRP-471850: One-step "convert to extension method" refactoring

October 15, 2018, 6:37 am
$
0
0
Reporter Dmitry Jemerov (yole) Dmitry Jemerov (yole)
Created Oct 15, 2018 4:26:21 PM
Updated Oct 15, 2018 4:37:07 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
RIght now, if I want to convert a method to an extension method, I need to perform a sequence of refactorings: make static, move to static class, convert to extension method. ReSharper should provide a one-step action to perform these operations. If there are already classes containing other extension methods for the same class, R# should offer them as destinations. It should also offer to create a new destination class.
↧

RSRP-329120: VB.NET people don't understand "abstract" - Please say "MustOverride"

October 15, 2018, 6:48 am
$
0
0
Reporter Denis Abramov (sparky2708) Denis Abramov (sparky2708)
Created Aug 9, 2012 7:40:56 PM
Updated Oct 15, 2018 4:48:51 PM
Resolved Aug 9, 2012 7:45:00 PM
Subsystem No Subsystem
Assignee Unassigned
Priority Major
State Duplicate
Type Unspecified
Fix version 7.1
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
VB.NET people don't understand "abstract" - Please say "MustOverride"
↧

RSRP-329119: VB.NET people don't understand "abstract" - should say "MustOverride"

October 15, 2018, 6:49 am
$
0
0
Reporter Denis Abramov (sparky2708) Denis Abramov (sparky2708)
Created Aug 9, 2012 7:37:12 PM
Updated Oct 15, 2018 4:49:30 PM
Resolved Oct 15, 2018 4:49:30 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Unspecified
Fix version Backlog
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
VB.NET people don't understand "abstract". Should say "MustOverride". See selected item in screenshot.
↧
Search

RSRP-337931: Create MustOverride Sub (R# 7.1)

October 15, 2018, 6:49 am
$
0
0
Reporter Denis Abramov (sparky2708) Denis Abramov (sparky2708)
Created Jan 30, 2013 10:57:14 PM
Updated Oct 15, 2018 4:49:30 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Major
State Submitted
Type Usability Problem
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
I am using VB.NET with R#7.1. So I wanted R# to create the method "Load" for me. Look at the options it is presenting me in the screenshot attached. As a "VB.NET" developer I am looking for "Create MustOverride Sub" which isn't part of the list. Interestingly there is "Create MustOverride Property" and "Create MustOverride ReadOnly Property". After looking at the list I do see "Create abstract class". This should really say "Create MustOverride Sub" for VB.NET developers, VB.NET developers aren't generally thinking of the word "abstract" unless you have a C#/Java background.

JetBrains ReSharper 7.1.1 Full Edition
Build 7.1.1000.900 on 2012-12-13T20:22:48
↧
↧

RSRP-330545: Generate class with namespace

October 15, 2018, 6:57 am
$
0
0
Reporter Julius Kunze (Blink) Julius Kunze (Blink)
Created Oct 4, 2012 7:08:33 PM
Updated Oct 15, 2018 4:57:23 PM
Subsystem Generate
Assignee Andrew Karpov (andrew.karpov)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 7.0.1, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
When I press Alt+Enter and then Enter in solution explorer I get a window where I can type a new name for a new class. It would be nice if I could type "SomeNamespace.SomeClass" there and resharper would generate the namespace "SomeNamespace" around my new class. (I use Vb and I'm not sure whether this is possible in C#.)
↧

RSRP-331948: Enable quicker property creation in destination class when it can be inferred

October 15, 2018, 7:02 am
$
0
0
Reporter Eric Williams (motowilliams) Eric Williams (motowilliams)
Created Oct 17, 2012 6:45:16 AM
Updated Oct 15, 2018 5:02:10 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
When Resharper can determine what the destination type is from the type system it should just show an option to just create the property (preferable an automatic property) in the destination class without taking the IDE to that class regardless of where that destination class is at in the solution.
↧

RSRP-471843: Sometimes high CPU usage plus memory leak while analyzing TypeScript files.

October 15, 2018, 7:06 am
$
0
0
Reporter Dmitrii Levchenko (dlxeon) Dmitrii Levchenko (dlxeon)
Created Oct 8, 2018 12:51:34 AM
Updated Oct 15, 2018 5:06:50 PM
Subsystem TypeScript
Assignee Nikita Popov (poksh)
Priority Normal
State Submitted
Type Performance Problem
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions

Sometimes when working on my Asp.net/C#/AngularJS/Typescript project, I got Rider 2018.2.3 to consume 100% of single CPU core and having continuously high memory usage (and growing) until I restart it. Perfview trace shows error somewhere in Typescript analyzer. Memory dump on attached screenshot was taken when process memory was slightly bigger, than 4Gb, while Task manager screenshot was taken later.

↧

RSRP-471851: Completion: expect switch, but get Switch instead

October 15, 2018, 7:09 am
$
0
0
Reporter Anna Milova (anna.milova) Anna Milova (anna.milova)
Created Oct 15, 2018 5:08:10 PM
Updated Oct 15, 2018 5:09:38 PM
Subsystem Complete Statement
Assignee Mikhail Senkov (micha)
Priority Critical
State Submitted
Type Bug
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
see repro screencast
failed intest: IntelliSensePreselectOvertypeTests.TestOvertypeSwitchCSharp
↧
↧

RSRP-337259: "Create overload for Sub" produces incorrect code for VB.Net.

October 15, 2018, 7:12 am
$
0
0
Reporter Sebastian (Andersson) Sebastian (Andersson)
Created Jan 14, 2013 12:48:29 PM
Updated Oct 15, 2018 5:12:45 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Bug
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Having this code:

Namespace A
Class A1
End Class
End Namespace

Namespace B
Class A1
End Class
End Namespace

Class C
Private _a As A.A1
Private _b As B.A1

Private Overloads Function Convert(a As Long) As Integer
Return CInt(a)
End Function

Public Sub D()
_a = Convert(_b) ' Choose "Create overload for Sub 'Convert'"
End Sub

End Class



If one chooses "Create overload for Sub 'Convert'" for the incorrect call to Convert, this code is produced:
Private Sub Convert()
Throw New NotImplementedException()
End Sub

It has no "overloads" keyword, no arguments, nor result value.


If one instead adds the follow code to the C class:

Private Overloads Function Convert(a As Byte) As Integer
Return CInt(a)
End Function

and then chooses "Create overload for Sub 'Convert'", this code is produced:

Private Function Convert(ByVal a1 As A1) As A1
Throw New NotImplementedException()
End Function


Once again the "overloads" keyword is missing, but this time the parameter and return value is correct, excepts that the namespaces are missing.
↧

RSRP-364504: Wrong default Quick fix selection for generating methods

October 15, 2018, 7:17 am
$
0
0
Reporter ibrahim dursun (idursun) ibrahim dursun (idursun)
Created May 22, 2013 12:44:44 PM
Updated Oct 15, 2018 5:17:35 PM
Subsystem Quick Fixes - Create From Usage
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Usability Problem
Fix version Backlog
Affected versions 7.1.1, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Default item in quick fix menu doesn't make sense at all. Besides, the most suitable fix is hidden under "Create Other" menu as if there are 1000 items in the quick fix menu so that it needed to be hidden inside a submenu. This contradicts with the claimed smartness of the Resharper.
↧
Search

RSRP-365636: When creating field, ReSharper should replace the type of the field/property, if they are incompatible (or at least produce a warning)

October 15, 2018, 7:22 am
$
0
0
Reporter Igal Tabachnik (hmemcpy) Igal Tabachnik (hmemcpy)
Created May 27, 2013 3:56:25 PM
Updated Oct 15, 2018 5:22:31 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Improvement
Fix version Backlog
Affected versions 8.0 EAP, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Suppose I have:

public class Foo
{
  private readonly string _myField;

  public Foo(int myField) <-- invoke introduce field
  {
  }
}

This will simply try assigning _myField = myField, without changing the type to int, causing a compilation error.
↧

RSRP-439690: Type Dependency Diagram works really bad when using dark theme in Visual Studio

October 15, 2018, 7:42 am
$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created May 13, 2015 4:37:12 PM
Updated Oct 15, 2018 5:42:10 PM
Subsystem Architecture Tools (Diagramms)
Assignee Alexander Ulitin (alexander.ulitin)
Priority Major
State Submitted
Type Cosmetics
Fix version No Fix versions
Affected versions 9.1
Fixed In Version ReSharper Undefined
VsVersion All Versions
I prefer using the Dark theme in Visual Studio, but i can't if I want to use the Type Dependency Diagram. By default, it looks really bad and pretty much useless.

Please test and fix the problem so that those of us who use the dark theme in Visual Studio aren't second-class citizens :)

If you look at the dark one, you can’t see the boxes ‘cause they’re the same color as the background. Perhaps a light frame around boxes would be better. Also, the text is very hard to read, especially the title.
↧
↧

RSRP-471852: "Cannot access static enum 'Class.Enum' in non-static context" error for a code implemented inside a class which has member with the same name as the enum.

October 15, 2018, 7:55 am
$
0
0
Reporter Andrey Simukov (Andrey.Simukov) Andrey Simukov (Andrey.Simukov)
Created Oct 15, 2018 5:54:20 PM
Updated Oct 15, 2018 5:55:27 PM
Subsystem Code Analysis - C#
Assignee Alexander Shvedov (shvedov)
Priority Normal
State Submitted
Type Bug
Fix version No Fix versions
Affected versions 2018.2.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
In the below error message (Cannot access static enum 'FilterType' in non-static context) there are a few problems:
1. I'm not sure what a "static enum" is. The enum is a public member of a public class with no mention of static for either. As far as I know an instance of an enum could be static but not the enum definition.
2. The solution builds with no errors
3. I have cleared all of the caches and am still getting this error - speaking of which, why don't you provide a menu item for doing this? You guys tell me to clear my solution caches to fix all sorts of problems, you should make it easier to do

The code where the error occurs is:
foreach (DictionaryEntry result in results)
           if (result.Key is Channel.FilterType) // <==== FilterType has squiggly red underline

The relevant part of the class definition is:
 public abstract class Channel : Subsystem, IMeasurementSource, IOperand
    {
         /// <summary>Filter Selections for Optical Channel.</summary>
        //[Obsolete("Should probably use property with actual value instead of using enumeration")]
        public enum FilterType
        {
#pragma warning disable 1591
            Unfiltered = 0,
            Filter1 = 1,
            Filter2,
            Filter3,
            Filter4,
            Filter5,
            Filter6,
            Filter7,
            Filter8,
            Filter9,
            Filter10,
            Filter11,
            Filter12,
            Filter13,
            Filter14,
            Filter15
#pragma warning restore 1591
        }
}



Another clue. If I add the namespace for Channel.FilterType the R# error goes away. But if I also add the namespace on the next line, that produces a "Qualifier is redundant" warning!
The new code is:
 if (result.Key is DCA.Channel.FilterType)
                    FilterSettings[(DCA.Channel.FilterType)result.Key].NewGain = MessageBoxX.SafeData(results, result.Key, 0.0);

↧

RSRP-386171: Try to detect assign to filed when you "Add another accessor"

October 15, 2018, 8:03 am
$
0
0
Reporter Magnus Mårtensson (noopman) Magnus Mårtensson (noopman)
Created Sep 10, 2013 2:02:12 AM
Updated Oct 15, 2018 6:03:55 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Improvement
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
private IResourceService resourceService;

public IResourceService ResourceService
{
     get { return resourceService ?? (resourceService = new NullResourceService()); }
}

Given the field and property above with only a getter accessor the "Add another accessor" action does not detect and suggest to add the assign to field implementation.

     set { resourceService = value; }

Two factors can help this detection: Naming convension with the field and property and also the fact that the field is used inside the getter.
↧

RSRP-471826: Resharper Installer needs local admin rights for Visual Studio 2017

October 15, 2018, 8:04 am
$
0
0
Reporter peter wellstein (petercosmic) peter wellstein (petercosmic)
Created Oct 12, 2018 4:01:08 PM
Updated Oct 15, 2018 6:04:27 PM
Subsystem Installation
Assignee Denis Korneev (Denis.Korneev)
Priority Normal
State Submitted
Type Bug
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
When trying to install JetBrains.ReSharperUltimate.2018.2.3.exe we face the issue that for integration with VS 2017 we apparently need local admin rights (not needed for VS2015). However this is prevented by company policy. Is there a way to get around it?
↧
Viewing all 106942 articles
Browse latest View live
Search
<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>