Quantcast
Channel: YouTrackReSharper (RSRP) - Bug and Issue Tracker
Viewing all 106942 articles
Browse latest View live
↧

RSRP-392181: Using VB .NET, if I have code that compares a double to 0 using "if myVar = 0" R# will suggest comparing against Epsilon

October 17, 2018, 7:15 am
$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created Nov 11, 2013 6:28:17 PM
Updated Oct 17, 2018 5:15:53 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Improvement
Fix version Backlog
Affected versions 8.1 EAP, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Using VB .NET, if I have code that compares a double to 0 using "if myVar = 0" R# will suggest comparing against Epsilon. Activating the correction generates "if Math.Abs(dataValue - 0) < TOLERANCE". I see two things wrong with this. First, TOLERANCE should default to Double.Epsilon and secondly, - 0 is unneeded in cases where we are comparing to 0 and should not be generated. This is a longstanding issue and not an 8.1 thing.
↧
Search

RSRP-275801: Fix double comparison should insert double.Epsilon

October 17, 2018, 7:15 am
$
0
0
Reporter Ilya Ryzhenkov (orangy) Ilya Ryzhenkov (orangy)
Created Sep 20, 2011 10:40:31 AM
Updated Oct 17, 2018 5:15:53 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State To be discussed
Type Improvement
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions 
private double _innerRadius = 0;
        public double InnerRadius
        {
            get { return _innerRadius; }
            set {
                if(_innerRadius == value) // use QF here
                    return;
                _innerRadius = value;
            }
        }
↧
↧

RSRP-471518: Rename: empty "Rename usages in comments and string literals" dialog is shown.

October 17, 2018, 7:16 am
$
0
0
Reporter Lilia Shamsutdinova (Lilia.Shamsutdinova) Lilia Shamsutdinova (Lilia.Shamsutdinova)
Created Sep 17, 2018 2:53:12 PM
Updated Oct 17, 2018 5:16:19 PM
Subsystem Refactorings
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Submitted
Type Bug
Fix version 2018.3
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions

JetBrains.ReSharperUltimate.2018.3.EAP1D.Checked.(183.0.20180917.42622-eap01d).

    // IInterface
    interface IInterface
    {
    }
  1. Invoke Rename on IInterface.
  2. Set IInterface1 as Name; check all checkboxes.
  3. Click Next.

Actual result:
Empty "Rename usages in comments and string literals" dialog is shown:

Expected result:
"Rename usages in comments and string literals" dialog displays // IInterface.

↧

RSRP-469060: Multiple opening of the form 'Filter issues' in the 'Find code issues results'

October 17, 2018, 7:27 am
$
0
0
Reporter Maltseva Ekaterina (Maltseva.Ekaterina) Maltseva Ekaterina (Maltseva.Ekaterina)
Created Apr 3, 2018 8:46:20 PM
Updated Oct 17, 2018 5:27:06 PM
Resolved Oct 17, 2018 5:27:06 PM
Subsystem Code Analysis - Find Code Issues
Assignee Mikhail Senkov (micha)
Priority Normal
State Fixed
Type Bug
Fix version Unidentified prior version
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
Open 'Inspections' / 'Code issues in solution'
In the window 'Code issues in <solution>' there is a button 'Filter issues'
You can click on in a lot of times and every time the new window will be open over the last

↧

RSRP-468385: Dataset visualizer missing in the new Resharper datatips.

October 17, 2018, 7:27 am
$
0
0
Reporter Tim Scheir (Tim.Scheir) Tim Scheir (Tim.Scheir)
Created Feb 15, 2018 1:46:32 PM
Updated Oct 17, 2018 5:27:35 PM
Resolved Oct 17, 2018 5:27:35 PM
Subsystem Debugger features
Assignee Mikhail Senkov (micha)
Priority Normal
State Fixed
Type Feature
Fix version Unidentified prior version
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions

I'm missing a dataset visualizer in the Resharper datatips for visual studio.
https://docs.microsoft.com/nl-be/visualstudio/debugger/dataset-visualizer-dialog-box

↧
↧

RSRP-471875: DocumentRange is invalid

October 17, 2018, 7:31 am
$
0
0
Reporter Miguel Pinto (enchoir) Miguel Pinto (enchoir)
Created Jul 17, 2018 11:51:51 AM
Updated Oct 17, 2018 5:31:09 PM
Subsystem Context Actions
Assignee Alexander Shvedov (shvedov)
Priority Show-stopper
State Submitted
Type Exception
Fix version 2018.3
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
ReSharperPlatformVs15 Wave 182 Hive _b33d9532 — JetBrains ReSharper Ultimate 2018.2 EAP 3 Build 182.0.20180711.65739-eap03

JetBrains dotTrace 182 Build 182.0.20180711.73821-eap03
JetBrains ReSharper 182 Build 182.0.20180711.70917-eap03
JetBrains TeamCity Add-in 182 Build 182.0.20180711.70915-eap03

DocumentRange is invalid

— EXCEPTION #1/2 [AssertionException]
Message = “DocumentRange is invalid”
ExceptionPath = Root.InnerException
ClassName = JetBrains.Util.Assertion+AssertionException
HResult = COR_E_EXCEPTION=80131500
Source = JetBrains.Platform.DocumentModel
StackTraceString = “
 at JetBrains.DocumentModel.DocumentRange.AssertValid()
…
 at JetBrains.DocumentModel.DocumentRange.AssertValid()
 at JetBrains.ReSharper.Intentions.CSharp.ContextActions.Comments.CSharpCommentActionBase.ValidateSelectionBorders(IFile cSharpFile, ICSharpCommentNode commentNode)
 at JetBrains.ReSharper.Intentions.CSharp.ContextActions.Comments.CSharpCommentActionBase.ValidateSelectionRange(IFile cSharpFile, IList`1 commentNodes)
 at JetBrains.ReSharper.Intentions.CSharp.ContextActions.Comments.CSharpCommentActionBase.GetSelectedCommentNodes()
 at JetBrains.ReSharper.Intentions.CSharp.ContextActions.Comments.UncommentAction.IsAvailable(IUserDataHolder cache)
 at JetBrains.ReSharper.Feature.Services.ContextActions.ContextActionTableImpl.InstantiateAvailableActions(IPsiSourceFile sourceFile, IDictionary`2 providersCache, IUserDataHolder dataHolder)
”

— Outer —

— EXCEPTION #2/2 [LoggerException]
Message = “DocumentRange is invalid”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
Data.ManagedThreadName = “JetPool(S) #1”
Data.SccRevisionShell = “<there are no packages matching the criteria>”
Data.HostProductInfo = “JetBrains ReSharper Ultimate 2018.2 EAP 3 Build 182.0.20180711.65739-eap03”
Data.SubProducts.#0 = “JetBrains dotTrace 182 Build 182.0.20180711.73821-eap03”
Data.SubProducts.#1 = “JetBrains TeamCity Add-in 182 Build 182.0.20180711.70915-eap03”
Data.SubProducts.#2 = “JetBrains ReSharper 182 Build 182.0.20180711.70917-eap03”
Data.SccRevisionEnv = “
Platform\Core\Shell:
    git::refs/heads/182-eap3::2b55a007014dea4b041ef04e3fd1893fb9820541


Platform\VisualStudio:
    git::refs/heads/182-eap3::7d305aa324a045fb7468c2cc6200e062bc531798
”
Data.VsVersion = 15.7.27703.2042
InnerException = “Exception #1 at Root.InnerException”
HResult = COR_E_APPLICATION=80131600
StackTraceString = “
 at JetBrains.ReSharper.Feature.Services.ContextActions.ContextActionTableImpl.InstantiateAvailableActions(IPsiSourceFile sourceFile, IDictionary`2 providersCache, IUserDataHolder dataHolder)
…
 at JetBrains.ReSharper.Feature.Services.ContextActions.ContextActionTableImpl.InstantiateAvailableActions(IPsiSourceFile sourceFile, IDictionary`2 providersCache, IUserDataHolder dataHolder)
 at JetBrains.ReSharper.Intentions.Bulbs.ContextActionsProvider.CollectActions(IntentionsBulbItems intentionsBulbItems, BulbItemsCache bulbItemsCache, ITextControl textControl, Lifetime caretPositionLifetime, IPsiSourceFile psiSourceFile, Object precalculatedData)
 at JetBrains.ReSharper.Intentions.Bulbs.BulbItems.<>c__DisplayClass21_0.<BuildAvailableActionsList>b__1()
 at JetBrains.Application.Threading.InterruptableReadActivityThe.Work()
 at JetBrains.Application.Threading.InterruptableReadActivity.DoWork()
 at JetBrains.Application.Threading.InterruptableReadActivity.WorkerThreadProc()
 at JetBrains.Util.Logging.Logger.Catch(Action action)
 at JetBrains.Application.Threading.Tasks.TaskHostEx.<>c__DisplayClass2_0.<RunSafe>b__0()
 at JetBrains.Application.Threading.Tasks.TaskHost.AccessViolationCatcher(Action action)
 at JetBrains.Application.Threading.Tasks.TaskHost.<>c__DisplayClass33_0.<Create>b__1(Object state)
 at System.Threading.Tasks.Task.InnerInvoke()
 at System.Threading.Tasks.Task.Execute()
 at System.Threading.Tasks.Task.ExecutionContextCallback(Object obj)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
 at System.Threading.Tasks.Task.ExecuteEntry(Boolean bPreventDoubleExecution)
 at System.Threading.Tasks.TaskScheduler.TryExecuteTask(Task task)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetScheduler.ExecuteTask(Task task)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.EnqueueNextTask()
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.ThreadPoolProc()
     at ANNOTATED: JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.JetPool(S) #1(Action )
 at JetBrains.Util.Reflection.CallStackAnnotation.InvokeAnnotated(String classNameOfNewFrame, String methodNameOfNewFrame, Action actionToAnnotate)
 at JetBrains.Util.Reflection.CallStackAnnotation.CatchAnnotatedInvocation[TClassOfNewFrame](String methodNameOfNewFrame, Action actionToAnnotate)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.<Start>b__19_0()
 at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
 at System.Threading.ThreadHelper.ThreadStart()
”
↧

RSRP-80754: OutOfMemoryException

October 17, 2018, 7:32 am
$
0
0
Reporter Ilya Ryzhenkov (orangy) Ilya Ryzhenkov (orangy)
Created Sep 16, 2008 10:30:37 AM
Updated Oct 17, 2018 5:32:14 PM
Subsystem Crash
Assignee Sergey Shkredov (serjic.shkredov)
Priority Critical
State Reopened
Type Exception
Fix version Backlog
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
↧

RSRP-471592: R# build checks out files from TFS

October 17, 2018, 7:56 am
$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created Sep 21, 2018 2:43:51 PM
Updated Oct 17, 2018 5:56:47 PM
Subsystem Solution builder
Assignee Tatyana Lunegova (lunega)
Priority Critical
State Waiting for Info
Type Task
Fix version Backlog
Affected versions 2018.2.3
Fixed In Version ReSharper Undefined
VsVersion All Versions

I found sometimes are unexpectedly opened files checked out from TFS when running application. This is related to R# build.

  1. Open any solution
  2. Open file from any other solution (important)
  3. Put cursor to this opened file (important)
  4. Run F5 or click on Run icon

File gets checked out even there is no edit or something.
It must be "out of solution" file and cursor must be placed inside (focused editor) before running debug.
Disabling R# build and using VS build works fine.

↧
Search

RSRP-396867: New Context Actions: i++ etc.

October 17, 2018, 7:58 am
$
0
0
Reporter Satoshi TERADA (Satoshi_TERADA) Satoshi TERADA (Satoshi_TERADA)
Created Nov 29, 2013 10:05:39 AM
Updated Oct 17, 2018 5:58:23 PM
Resolved Oct 17, 2018 5:58:23 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Feature
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
How about these new C# context action?
i = i+1; into i++;
i=i-1; into i–;
s=s+"add" into s+="add"
etc.
↧
↧

RSRP-471765: The given key was not present in the dictionary.

October 17, 2018, 7:58 am
$
0
0
Reporter Lilia Shamsutdinova (Lilia.Shamsutdinova) Lilia Shamsutdinova (Lilia.Shamsutdinova)
Created Sep 19, 2018 11:03:06 AM
Updated Oct 17, 2018 5:58:28 PM
Subsystem Build Scripts
Assignee Anton Spilnyy (Anton.Spilnyy)
Priority Normal
State Submitted
Type Exception
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
ReSharperPlatformVs15 Wave 183 Hive _3f3919c0 — JetBrains ReSharper Ultimate 2018.3 EAP 1 D Build 183.0.20180919.22621-eap01d

JetBrains dotCover 2018.3 EAP 1 D Build 2018.3.20180919.24125-eap01d
JetBrains dotMemory 2018.3 EAP 1 D Build 2018.3.20180919.23937-eap01d
JetBrains dotTrace 2018.3 EAP 1 D Build 2018.3.20180919.24133-eap01d
JetBrains ReSharper 2018.3 EAP 1 D Build 2018.3.20180919.23820-eap01d
JetBrains ReSharper C++ 2018.3 EAP 1 D Build 2018.3.20180919.23820-eap01d
JetBrains TeamCity Add-in 2018.3 EAP 1 D Build 2018.3.20180919.23833-eap01d

The given key was not present in the dictionary.

— EXCEPTION #1/2 [KeyNotFoundException]
Message = “The given key was not present in the dictionary.”
ExceptionPath = Root.InnerException
ClassName = System.Collections.Generic.KeyNotFoundException
HResult = COR_E_KEYNOTFOUND=80131577
Source = mscorlib
StackTraceString = “
 at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
…
 at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
 at JetBrains.ReSharper.Psi.BuildScripts.ReferenceManager.GetMappedFile(IEnumerable`1 nodes, IDictionary`2 mapping)
 at JetBrains.ReSharper.Psi.BuildScripts.ReferenceManager.BuildDeclaredElements(BuildScriptGraph graph)
 at JetBrains.ReSharper.Psi.BuildScripts.InclusionEngine.BuildScriptCache.ForceGraphLoad()
 at JetBrains.ReSharper.Psi.BuildScripts.InclusionEngine.BuildScriptCache.CheckBuildScriptGraph()
 at JetBrains.ReSharper.Psi.BuildScripts.InclusionEngine.BuildScriptCache.BuildStateForFile(IPsiSourceFile psiSourceFile, Boolean isStartup)
 at JetBrains.ReSharper.Psi.BuildScripts.InclusionEngine.BuildScriptCache.Build(IPsiSourceFile sourceFile, Boolean isStartup)
 at JetBrains.ReSharper.Psi.Caches.Jobs.JobUpdateProjectFiles.<>c__DisplayClass14_0.<BuildSourceFile>b__0()
”

— Outer —

— EXCEPTION #2/2 [LoggerException]
Message = “The given key was not present in the dictionary.”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
Data.ManagedThreadName = “JetPool(S) #5”
Data.SccRevisionShell = “<there are no packages matching the criteria>”
Data.HostProductInfo = “JetBrains ReSharper Ultimate 2018.3 EAP 1 D Build 183.0.20180919.22621-eap01d”
Data.SubProducts.#0 = “JetBrains dotCover 2018.3 EAP 1 D Build 2018.3.20180919.24125-eap01d”
Data.SubProducts.#1 = “JetBrains dotTrace 2018.3 EAP 1 D Build 2018.3.20180919.24133-eap01d”
Data.SubProducts.#2 = “JetBrains ReSharper C++ 2018.3 EAP 1 D Build 2018.3.20180919.23820-eap01d”
Data.SubProducts.#3 = “JetBrains TeamCity Add-in 2018.3 EAP 1 D Build 2018.3.20180919.23833-eap01d”
Data.SubProducts.#4 = “JetBrains ReSharper 2018.3 EAP 1 D Build 2018.3.20180919.23820-eap01d”
Data.SubProducts.#5 = “JetBrains dotMemory 2018.3 EAP 1 D Build 2018.3.20180919.23937-eap01d”
Data.SccRevisionEnv = “
Platform\Core\Shell:
    git::refs/heads/183::5d0d97d12df0d17c8a4183b9ac7f76b286efbc04


Platform\VisualStudio:
    git::refs/heads/183
”
Data.VsVersion = 15.8.28010.2026
InnerException = “Exception #1 at Root.InnerException”
HResult = COR_E_APPLICATION=80131600
StackTraceString = “
 at JetBrains.ReSharper.Psi.Caches.Jobs.JobUpdateProjectFiles.<>c__DisplayClass14_0.<BuildSourceFile>b__0()
…
 at JetBrains.ReSharper.Psi.Caches.Jobs.JobUpdateProjectFiles.<>c__DisplayClass14_0.<BuildSourceFile>b__0()
 at JetBrains.Util.Logging.ILoggerStructuredEx.DoCalculation[T](LoggerWithSeverity logger, String key, String message, Func`1 action, Func`2 report)
 at JetBrains.ReSharper.Psi.Caches.Jobs.JobUpdateProjectFiles.BuildSourceFile(IPsiSourceFile sourceFile, IDocument doc)
 at JetBrains.ReSharper.Psi.Caches.Jobs.JobUpdateProjectFiles.<>c__DisplayClass13_1.<ExecuteUpdate>b__1(IPsiSourceFile file, IDocument doc)
 at JetBrains.ReSharper.Psi.Caches.Jobs.CacheJobService2.<>c__DisplayClass37_0`2.<WrappedJob>b__0()
 at JetBrains.ReSharper.Psi.Caches.Jobs.CacheJobService2.<>c__DisplayClass35_0`2.<ExecuteWithPrerocessAndInterrupt>b__1(T x, TPreprocessResult y)
 at JetBrains.Application.Threading.Tasks.TaskHostEx.<>c__DisplayClass5_1`2.<PreprocessSingleThreadedAndParallelize>b__1()
 at JetBrains.Application.Threading.Tasks.TaskHost.AccessViolationCatcher(Action action)
 at JetBrains.Application.Threading.Tasks.TaskHost.<>c__DisplayClass33_0.<Create>b__1(Object state)
 at System.Threading.Tasks.Task.InnerInvoke()
 at System.Threading.Tasks.Task.Execute()
 at System.Threading.Tasks.Task.ExecutionContextCallback(Object obj)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
 at System.Threading.Tasks.Task.ExecuteEntry(Boolean bPreventDoubleExecution)
 at System.Threading.Tasks.TaskScheduler.TryExecuteTask(Task task)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetScheduler.ExecuteTask(Task task)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.EnqueueNextTask()
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.ThreadPoolProc()
     at ANNOTATED: JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread #3.JetPool(S) #5(Action )
 at JetBrains.Util.Reflection.CallStackAnnotation.InvokeAnnotated(String classNameOfNewFrame, String methodNameOfNewFrame, Action actionToAnnotate)
 at JetBrains.Util.Reflection.CallStackAnnotation.CatchAnnotatedInvocation[TClassOfNewFrame](String methodNameOfNewFrame, Action actionToAnnotate)
 at JetBrains.Application.Threading.Tasks.Scheduler.JetSchedulerThread.<Start>b__20_0()
 at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
 at System.Threading.ThreadHelper.ThreadStart()
”
↧

RSRP-122593: CA to convert "a=a+b" to "a+=b" and back again

October 17, 2018, 7:59 am
$
0
0
Reporter Drew Noakes (drewnoakes) Drew Noakes (drewnoakes)
Created Sep 24, 2009 5:29:47 PM
Updated Oct 17, 2018 5:59:19 PM
Subsystem Context Actions
Assignee Andrew Karpov (andrew.karpov)
Priority Normal
State Open
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
This applies to many operators: + - / * | & ^

I don't know confidently whether you could suggest the contraction. At a glance, it seems like it would be a safe suggestion. Either way, having a CA to toggle between representations would be useful.
↧

RSRP-400260: Ternary expression to if condition in Razor

October 17, 2018, 8:08 am
$
0
0
Reporter Alexander Kurakin (Alexander.Kurakin) Alexander Kurakin (Alexander.Kurakin)
Created Dec 16, 2013 12:01:06 PM
Updated Oct 17, 2018 6:08:30 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
it would be nice if this could be converted to an if

return View("Index", localConfig.CodeCampType == "conf"
? "~/Views/Shared/_LayoutConf.cshtml"
: "~/Views/Shared/_Layout.cshtml", viewModel);
↧

RSRP-402828: "Check if device not null" modifies code incorrectly, places braces incorrectly

October 17, 2018, 8:11 am
$
0
0
Reporter Charles Burns (Charles_Burns) Charles Burns (Charles_Burns)
Created Feb 4, 2014 3:45:58 AM
Updated Oct 17, 2018 6:11:45 PM
Subsystem Quick Fixes
Assignee Alisa Afonina (alisa.afonina)
Priority Critical
State Submitted
Type Bug
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
Original code:

public RequestResponseModel Get(string process, string device = null, string lev_no = "", bool xadj = true, bool xmag1 = true) {
    process = process.ToUpperInvariant();
    device = device.ToUpperInvariant();
    if (!String.IsNullOrWhiteSpace(process) && !String.IsNullOrWhiteSpace(device)) {
        try {
            var rows = Database.Query("connstr", sqlReticleDatabase.select,
                new {process, device, lev_no, xadj = xadj ? 1 : 0, xmag1 = xmag1 ? 1 : 0});
            Response.aaData = rows;
        }
        catch (Exception e) {
            Response.error = e.Message;
        }
    }
    else Response.aaData = new List<string>();

    return Response;
}

I get "Possible System.NullReferenceException" for the line: device = device.ToUpperInvariant();

When I select "Check if 'device' not null (Alt+Enter)" the resulting code is:

public RequestResponseModel Get(string process, string device = null, string lev_no = "", bool xadj = true, bool xmag1 = true) {
    process = process.ToUpperInvariant();
    if (device != null) {
        device = device.ToUpperInvariant();

        if (!String.IsNullOrWhiteSpace(process) && !String.IsNullOrWhiteSpace(device)) {
            try {
                var rows = Database.Query("connstr", sqlReticleDatabase.@select,
                    new {process, device, lev_no, xadj = xadj ? 1 : 0, xmag1 = xmag1 ? 1 : 0});
                Response.aaData = rows;
            }
            catch (Exception e) {
                Response.error = e.Message;
            }
        }
        else Response.aaData = new List<string>();
    }

    return Response;
}

As you can see, it changed the scope of the entire method and for some reason added the '@' character to sqlReticleDatabase.select, which is totally unrelated.

It should have changed just the aforementioned line to: if (device != null) device = device.ToUpperInvariant();
↧
↧

RSRP-471860: TextView has disconnected from TextControl on TextViewDataChanged.

October 17, 2018, 8:19 am
$
0
0
Reporter ReSharper anonymous (resharper) ReSharper anonymous (resharper)
Created Oct 9, 2018 6:07:02 PM
Updated Oct 17, 2018 6:19:57 PM
Subsystem No Subsystem
Assignee Denis Korneev (Denis.Korneev)
Priority Critical
State Submitted
Type Exception
Fix version No Fix versions
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
ReSharperPlatformVs15 Wave 183 Hive _c04239a4 — JetBrains ReSharper Ultimate 2018.3 EAP 1 Build 183.0.20181005.161021-eap01

JetBrains dotCover 2018.3 EAP 1 Build 2018.3.20181005.162547-eap01
JetBrains dotMemory 2018.3 EAP 1 Build 2018.3.20181005.162416-eap01
JetBrains dotTrace 2018.3 EAP 1 Build 2018.3.20181005.162553-eap01
JetBrains ReSharper 2018.3 EAP 1 Build 2018.3.20181005.162249-eap01

TextView has disconnected from TextControl on TextViewDataChanged.

— EXCEPTION #1/1 [LoggerException]
Message = “TextView has disconnected from TextControl on TextViewDataChanged.”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
Data.ManagedThreadName = <NULL>
Data.SccRevisionShell = “<there are no packages matching the criteria>”
Data.HostProductInfo = “JetBrains ReSharper Ultimate 2018.3 EAP 1 Build 183.0.20181005.161021-eap01”
Data.SubProducts.#0 = “JetBrains dotCover 2018.3 EAP 1 Build 2018.3.20181005.162547-eap01”
Data.SubProducts.#1 = “JetBrains dotTrace 2018.3 EAP 1 Build 2018.3.20181005.162553-eap01”
Data.SubProducts.#2 = “JetBrains ReSharper 2018.3 EAP 1 Build 2018.3.20181005.162249-eap01”
Data.SubProducts.#3 = “JetBrains dotMemory 2018.3 EAP 1 Build 2018.3.20181005.162416-eap01”
Data.SccRevisionEnv = “
Platform\Core\Shell:
    git::refs/heads/183-eap1::0eb0065d062c9bfc4eb1590bcaf200021b887a20


Platform\VisualStudio:
    git::refs/heads/183-eap1::e3ef340faae02e8bc8af03a0370466b734b63622
”
Data.VsVersion = 15.8.28010.2041
HResult = COR_E_APPLICATION=80131600
StackTraceString = “
 at JetBrains.Application.Threading.IShellLocksEx.ExecuteWithReadLock(IShellLocks thіs, Action F)
…
 at JetBrains.Application.Threading.IShellLocksEx.ExecuteWithReadLock(IShellLocks thіs, Action F)
 at JetBrains.Platform.VisualStudio.SinceVs10.TextControl.AttachTextControlsToTextViews.VsTextViewDataForTextControlCollectorDevTen.<>c__DisplayClass0_1.<.ctor>b__6(EventArgs`1 args)
 at JetBrains.DataFlow.Signal`1.NotifySinks(TValue payload)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value, Object cookie)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value)
 at JetBrains.Platform.VisualStudio.SinceVs10.TextControl.AttachTextControlsToTextViews.TrackVsTextViewDataForTextControlChangesEx.<>c__DisplayClass0_0.<FireTextViewDataChanged>b__0()
 at JetBrains.Platform.VisualStudio.SinceVs10.TextControl.AttachTextControlsToTextViews.TrackVsTextViewDataForTextControlChangesEx.FireTextViewDataChangedImpl(ITrackVsTextViewDataForTextControlChanges trackVsTextViewDataForTextControlChanges, Lifetime lifetime, IShellLocks locks, Action action)
 at JetBrains.Platform.VisualStudio.SinceVs10.TextControl.AttachTextControlsToTextViews.TrackVsTextViewDataForTextControlChangesEx.FireTextViewDataChanged(ITrackVsTextViewDataForTextControlChanges trackVsTextViewDataForTextControlChanges, Lifetime lifetime, IShellLocks locks, Func`1 isEventStillActual, IWpfTextView wpfTextView)
 at JetBrains.Platform.VisualStudio.SinceVs10.IDE.VsDocumentManagerWhidbey_TrackVsTextViewDataForTextControlChanges.<>c__DisplayClass0_0.<.ctor>b__2()
 at JetBrains.UI.Application.LocalReentrancyGuard.TryExecute(Action action)
 at JetBrains.Platform.VisualStudio.SinceVs10.IDE.VsDocumentManagerWhidbey_TrackVsTextViewDataForTextControlChanges.<>c__DisplayClass0_1.<.ctor>b__0(EventArgs`1 args)
 at JetBrains.DataFlow.Signal`1.NotifySinks(TValue payload)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value, Object cookie)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value)
 at JetBrains.VsIntegration.ProjectDocuments.VsDocumentManagerWhidbey.OnRegisterTextBuffer(VsTextBufferData textBufferData, Boolean forceReregisterEventProjectFileIsTheSame)
 at JetBrains.VsIntegration.ProjectDocuments.VsDocumentManagerWhidbey.<>c__DisplayClass26_0.<OnRdtAfterFirstDocumentLock>b__0()
 at JetBrains.Application.Threading.IShellLocksEx.ExecuteWithReadLock(IShellLocks thіs, Action F)
 at JetBrains.VsIntegration.ProjectDocuments.VsDocumentManagerWhidbey.<>c__DisplayClass23_0.<ExecuteOrQueueOrMergeUnguardedCallbackWithLog>b__0()
 at JetBrains.Util.Concurrency.UnguardedCallbackMerger.<>c__DisplayClass8_1.<ExecuteOrQueueOrMerge>b__0()
 at JetBrains.Threading.ReentrancyGuard.Execute(String name, Action action)
 at JetBrains.Threading.ReentrancyGuard.TryExecute(String name, Action action)
 at JetBrains.Threading.ReentrancyGuardEx.ExecuteOrQueue(ReentrancyGuard thіs, Lifetime lifetime, String name, Action F, TaskPriority priority)
 at JetBrains.Util.Concurrency.UnguardedCallbackMerger.ExecuteOrQueueOrMerge(Lifetime lifetimeQueue, String name, Action F)
 at JetBrains.VsIntegration.ProjectDocuments.VsDocumentManagerWhidbey.ExecuteOrQueueOrMergeUnguardedCallbackWithLog(String eventName, VSCOOKIE docCookie, Action action)
 at JetBrains.VsIntegration.ProjectDocuments.VsDocumentManagerWhidbey.OnRdtAfterFirstDocumentLock(EventArgs`1 args)
 at JetBrains.DataFlow.Signal`1.NotifySinks(TValue payload)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value, Object cookie)
 at JetBrains.DataFlow.Signal`1.Fire(TValue value)
 at JetBrains.VsIntegration.Interop.Events.DocumentModel.VsRunningDocumentTableEvents.Sink.<>c__DisplayClass4_0.<OnAfterFirstDocumentLock>b__0()
 at JetBrains.VsIntegration.Interop.Events.DocumentModel.VsRunningDocumentTableEvents.Sink.<>c__DisplayClass3_0.<FireSignalWithLog>b__0()
 at JetBrains.Util.Logging.Logger.Catch(Action action)
 at JetBrains.VsIntegration.Interop.Events.DocumentModel.VsRunningDocumentTableEvents.Sink.FireSignalWithLog(Action fireAction, String format, Object[] args)
 at JetBrains.VsIntegration.Interop.Events.DocumentModel.VsRunningDocumentTableEvents.Sink.OnAfterFirstDocumentLock(UInt32 docCookie, UInt32 dwRdtLockType, UInt32 dwReadLocksRemaining, UInt32 dwEditLocksRemaining)
 at JetBrains.VsIntegration.Interop.Events.DocumentModel.VsRunningDocumentTableEvents.Sink.Microsoft.VisualStudio.Shell.Interop.IVsRunningDocTableEvents.OnAfterFirstDocumentLock(UInt32 docCookie, UInt32 dwRdtLockType, UInt32 dwReadLocksRemaining, UInt32 dwEditLocksRemaining)
 at Microsoft.VisualStudio.Shell.Interop.IVsRunningDocumentTable2.FindOrRegisterAndLockDocument(UInt32 grfRDTLockType, String pszMkDocument, IVsHierarchy pHierPreferred, UInt32 itemidPreferred, IntPtr punkDocData, IVsHierarchy& ppHierActual, UInt32& pitemidActual, IntPtr& ppunkDocDataActual, UInt32& pdwCookie)
 at Microsoft.VisualStudio.Platform.WindowManagement.Rdt.FindOrRegisterAndLockDocument(RdtFlags flags, String moniker, IVsHierarchy hier, UInt32 itemID, IntPtr punkDocData, RdtLock& rdtLock)
 at Microsoft.VisualStudio.Platform.WindowManagement.DocumentObjectSite.RegisterAndLockDocData(String lpstrMkDoc, RdtFlags rdtLockType, Object docData)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.set_DocumentSite(DocumentObjectSite value)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService.CreateContentPane(FrameMoniker frameMoniker, Boolean isDocument, String lpstrMkDoc, UInt32 eCreateWindowFlags, Object punkView, Object punkData, IServiceProvider pServiceProvider, IVsUIHierarchy pUIHierarchy, UInt32 vsid, Guid rguidCmdUI, ViewGroup parent, IVsWindowFrame& ppWindowFrame)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService.CreateContentPane(String pszName, Int32 fDockViewOn, Int32 fDocument, String lpstrMkDoc, UInt32 eCreateWindowFlags, UInt32 dwToolWinId, Object punkView, Object punkData, IServiceProvider pServiceProvider, IVsUIHierarchy pUIHierarchy, UInt32 vsid, Int32& pfDefaultPosition, Guid& rguidCmdUI, IVsWindowFrame& ppWindowFrame)
 at Microsoft.VisualStudio.Shell.Interop.IVsProject2.ReopenItem(UInt32 itemid, Guid& rguidEditorType, String pszPhysicalView, Guid& rguidLogicalView, IntPtr punkDocDataExisting, IVsWindowFrame& ppWindowFrame)
 at Microsoft.VisualStudio.Platform.WindowManagement.SolutionOptions.ReopenDocumentFrame(WindowManagerService windowManager, StubWindowInfo stubInfo, ReopenDocumentOptions options, DocumentGroup docGroup, Int32& hr)
 at Microsoft.VisualStudio.Platform.WindowManagement.SolutionOptions.ReopenDocumentFrame(IWindowManagerPrivate windowManager, StubWindowInfo stubInfo, ReopenDocumentOptions options, DocumentGroup docGroup, Int32& hr)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.EnsureStubFrameInitialized(Boolean show, StubWindowInitializationReason reason)
 at Microsoft.VisualStudio.Platform.WindowManagement.StubWindowInfo.Microsoft.Internal.VisualStudio.Shell.Interop.IVsStubWindowPrivate.EnsureLoaded()
 at Microsoft.Internal.VisualStudio.Shell.Interop.IVsRunningDocumentTablePrivate.NotifyOnBeforeShow(UInt32 docCookie, Int32 fFirstShow, IVsWindowFrame pFrame)
 at Microsoft.VisualStudio.Platform.WindowManagement.Rdt.NotifyOnBeforeShow(UInt32 cookie, Boolean firstShow, IVsWindowFrame frame)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.NotifyFrameShowing(UInt32 cookie, Boolean firstShow)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.ShowInternal(ShowFlags showFlags)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.EnsureContentConstructed()
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.Activate()
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService.viewManager_ActiveViewChanged(Object sender, ActiveViewChangedEventArgs e)
 at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
 at Microsoft.VisualStudio.PlatformUI.ExtensionMethods.RaiseEvent[TEventArgs](EventHandler`1 eventHandler, Object source, TEventArgs args)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewManager.SetActiveView(View view, ActivationType type)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewManager.ActivateViewFromTabControl(TabControl tabControl, ActivationType type)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewManager.OnTabControlSelectionChanged(Object sender, SelectionChangedEventArgs args)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewManager.<>c.<.cctor>b__23_27(Object sender, SelectionChangedEventArgs args)
 at System.Windows.Controls.SelectionChangedEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
 at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
 at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
 at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
 at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
 at System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
 at System.Windows.Controls.TabControl.OnSelectionChanged(SelectionChangedEventArgs e)
 at Microsoft.VisualStudio.PlatformUI.LayoutSynchronizedTabControl.OnSelectionChanged(SelectionChangedEventArgs e)
 at System.Windows.Controls.Primitives.Selector.InvokeSelectionChanged(List`1 unselectedInfos, List`1 selectedInfos)
 at System.Windows.Controls.Primitives.Selector.SelectionChanger.End()
 at System.Windows.Controls.Primitives.Selector.SelectionChanger.SelectJustThisItem(ItemInfo info, Boolean assumeInItemsCollection)
 at System.Windows.Controls.Primitives.Selector.OnSelectedItemChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
 at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
 at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
 at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
 at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType)
 at System.Windows.DependencyObject.InvalidateProperty(DependencyProperty dp, Boolean preserveCurrentValue)
 at System.Windows.Data.BindingExpressionBase.Invalidate(Boolean isASubPropertyChange)
 at System.Windows.Data.BindingExpression.TransferValue(Object newValue, Boolean isASubPropertyChange)
 at System.Windows.Data.BindingExpression.ScheduleTransfer(Boolean isASubPropertyChange)
 at MS.Internal.Data.ClrBindingWorker.NewValueAvailable(Boolean dependencySourcesChanged, Boolean initialValue, Boolean isASubPropertyChange)
 at MS.Internal.Data.PropertyPathWorker.UpdateSourceValueState(Int32 k, ICollectionView collectionView, Object newValue, Boolean isASubPropertyChange)
 at MS.Internal.Data.PropertyPathWorker.OnDependencyPropertyChanged(DependencyObject d, DependencyProperty dp, Boolean isASubPropertyChange)
 at MS.Internal.Data.ClrBindingWorker.OnSourceInvalidation(DependencyObject d, DependencyProperty dp, Boolean isASubPropertyChange)
 at System.Windows.Data.BindingExpression.HandlePropertyInvalidation(DependencyObject d, DependencyPropertyChangedEventArgs args)
 at System.Windows.Data.BindingExpressionBase.OnPropertyInvalidation(DependencyObject d, DependencyPropertyChangedEventArgs args)
 at System.Windows.Data.BindingExpression.OnPropertyInvalidation(DependencyObject d, DependencyPropertyChangedEventArgs args)
 at System.Windows.DependentList.InvalidateDependents(DependencyObject source, DependencyPropertyChangedEventArgs sourceArgs)
 at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
 at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType)
 at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType, Boolean isInternal)
 at Microsoft.VisualStudio.PlatformUI.Shell.NestedGroup.UpdateSelectionCore(Int32 oldIndex)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewGroup.UpdateSelection(Int32 previousSelectionIndex)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewGroup.OnChildVisibilityChanged(ViewElement item)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewElement.OnIsVisibleChanged()
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewElement.OnIsVisibleChanged(DependencyObject obj, DependencyPropertyChangedEventArgs args)
 at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
 at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
 at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType)
 at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType, Boolean isInternal)
 at Microsoft.VisualStudio.PlatformUI.Shell.View.Hide()
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.<Hide>b__480_0()
 at Microsoft.VisualStudio.ErrorHandler.CallWithCOMConvention(Func`1 method, Boolean reportError, Boolean setShellErrorInfo)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.Hide()
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.DisposeManagedResources()
 at Microsoft.VisualStudio.PlatformUI.DisposableObject.Dispose(Boolean disposing)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.<>c__DisplayClass452_0.<CloseFrame>b__0()
 at Microsoft.VisualStudio.ErrorHandler.CallWithCOMConvention(Func`1 method, Boolean reportError, Boolean setShellErrorInfo)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.CloseFrame(__FRAMECLOSE frameClose)
 at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.frameView_Hiding(Object sender, CancelEventArgs e)
 at Microsoft.VisualStudio.PlatformUI.ExtensionMethods.RaiseEvent(CancelEventHandler eventHandler, Object source, CancelEventArgs args)
 at Microsoft.VisualStudio.PlatformUI.Shell.View.RaiseHiding()
 at Microsoft.VisualStudio.PlatformUI.Shell.View.Hide()
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewManager.OnHideViewCore(ViewElement closingViewElement, Boolean hideOnlyActiveView)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewManager.OnHideView(Object sender, ExecutedRoutedEventArgs args)
 at Microsoft.VisualStudio.PlatformUI.Shell.ViewManager.<>c.<.cctor>b__23_9(Object sender, ExecutedRoutedEventArgs args)
 at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
 at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
 at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
 at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
 at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
 at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
 at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
 at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
 at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
 at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
 at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
 at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
 at System.Windows.Input.RoutedCommand.Execute(Object parameter, IInputElement target)
 at Microsoft.VisualStudio.Platform.WindowManagement.DocumentTabItemStyle.OnMouseDown(Object sender, MouseButtonEventArgs e)
 at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
 at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
 at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
 at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
 at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
 at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
 at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
 at System.Windows.Input.InputManager.ProcessStagingArea()
 at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
 at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
 at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
 at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
 at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
 at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
 at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
 at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
 at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
”
↧

RSRP-471883: [Performance Report] Poor performance when typing with R# active

October 17, 2018, 8:25 am
$
0
0
Reporter Oliver Shelsher (oshelsher) Oliver Shelsher (oshelsher)
Created Oct 17, 2018 6:25:10 PM
Updated Oct 17, 2018 6:25:11 PM
Subsystem No Subsystem
Assignee Sergey Kuks (coox)
Priority Show-stopper
State Open
Type Performance Problem
Fix version 2018.3
Affected versions No Affected versions
Fixed In Version ReSharper Undefined
VsVersion All Versions
Evaluator: False
OS Version: Microsoft Windows NT 6.1.7601 Service Pack 1
Product: ReSharper, Version: 2018.2.20180912.160227
Time Zone: GMT Standard Time

Description

When typing into a text file with reharper active, my system CPU usage shoots up to 100% and the typing experience feels very poor (with spikes in input latency of up to one second). If I disable the Resharper extension, the issue clears up.

I have updated my installation of Resharper and Visual Studio to the latest versions.

Please could you assist?
↧
Search

RSRP-307962: Change resources to using

October 17, 2018, 8:28 am
$
0
0
Reporter Alex Berezoutsky (fergard) Alex Berezoutsky (fergard)
Created Jun 5, 2012 4:29:21 PM
Updated Oct 17, 2018 6:28:29 PM
Resolved Oct 17, 2018 6:28:29 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Duplicate
Type Feature
Fix version Backlog
Affected versions 6.1.1, 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions
If resharper doesn't do this then this is a suggestion. Does resharper take and replace something like

sqlConnection.Connection.open()
... do stuff with sql connection
sqlConnection.Connection.close()

and suggest making it into using 
(sqlConnection = new sqlConnection()) {
sqlConnection.connection.open()
.... do something with the sql co
}
↧

RSRP-200037: Context action: Introduce variable in "using" clause

October 17, 2018, 8:28 am
$
0
0
Reporter Dmitry Osinovsky (Dmitry.Osinovsky) Dmitry Osinovsky (Dmitry.Osinovsky)
Created Dec 9, 2010 10:02:06 PM
Updated Oct 17, 2018 6:28:29 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.2
Fixed In Version ReSharper Undefined
VsVersion All Versions
If an expression is of type that implements IDisplose, then there should be a context action to introduce variable in "using" clause. For example, if you'd invoke it for an expression:
new FileStream("aaa", FileMode.Create, FileAccess.Read)

Then you should receive:
using (var fileStream = new FileStream("aaa", FileMode.Create, FileAccess.Read))
{

}
↧
↧

RSRP-414467: Invalid refactoring hint for (T)nullvalue.

October 17, 2018, 8:43 am
$
0
0
Reporter Martin Suchan (Martin.Suchan) Martin Suchan (Martin.Suchan)
Created May 13, 2014 2:05:15 PM
Updated Oct 17, 2018 6:43:05 PM
Resolved Oct 17, 2018 6:43:05 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Obsolete
Type Bug
Fix version No Fix versions
Affected versions 8.2.1
Fixed In Version ReSharper Undefined
VsVersion VS 2013 RTM
See the code sample - ReSharper is hinting to change the method call DoStuff((T)parameter) to DoStuff(null), which is invalid if the DoStuff method accepts generic type, that has no restriction for reference type.

R# 8.2.1 RC, VS2013 Update 2 RTM, WP8 project

public class GenericClass<T>
{
    public void Execute(object parameter)
    {
        if (parameter == null)
        {
            if (typeof(T).GetTypeInfo().IsValueType)
                DoStuff(default(T));
            else
                DoStuff((T)parameter);
        }
        else
            DoStuff((T)parameter);
    }

    private void DoStuff(T value)
    {
        Debug.WriteLine(value);
    }
}
↧

RSRP-415878: Inconsistency in 'Add name to argument' context action

October 17, 2018, 8:45 am
$
0
0
Reporter Dmitry Matveev (Dmitry.Matveev) Dmitry Matveev (Dmitry.Matveev)
Created Jun 5, 2014 5:36:08 PM
Updated Oct 17, 2018 6:45:37 PM
Resolved Oct 17, 2018 6:45:37 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Normal
State Fixed
Type Bug
Fix version Unidentified prior version
Affected versions 8.2
Fixed In Version ReSharper Undefined
VsVersion All Versions
The description of this CA says 'Adds name to selected argument', and when I call it on the example below, it says 'Add argument name c', that is, it should add it only to the first argument,where the caret is..

.. but in fact, it adds names to all arguments, and this behavior is supported by the tests:

namespace ForDebug
/// before
{
  class Class2
  {
    void Foo()
    {
      Foo3({caret}null, 1, 1);
    }
    public static void Foo3(C c, int a, int b = 0)
    {
    }
  }
}    
// After
namespace ForDebug
{
  class Class2
  {
    void Foo()
    {
      Foo3(c: null, a: 1, b: 1);
    }
    public static void Foo3(C c, int a, int b = 0)
    {
    }
  }
}
↧

RSRP-417641: CA to exchange 'if' order for nested 'if'-s

October 17, 2018, 8:51 am
$
0
0
Reporter Anton Lobov (Anton.Lobov) Anton Lobov (Anton.Lobov)
Created Jul 7, 2014 4:05:39 PM
Updated Oct 17, 2018 6:51:18 PM
Subsystem Context Actions
Assignee Alisa Afonina (alisa.afonina)
Priority Minor
State Submitted
Type Feature
Fix version Backlog
Affected versions 2018.3
Fixed In Version ReSharper Undefined
VsVersion All Versions 
 if (a && b) {
      {caret}if (c && d) {
         // some code
      }
 }

Wanted result:
 if (c && d) {
      if (a && b) {
         // some code
      }
 }
↧
Viewing all 106942 articles
Browse latest View live
Search
<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>